yesamer commented on PR #2853: URL: https://github.com/apache/incubator-kie-tools/pull/2853#issuecomment-2598229111
@kumaradityaraj @fantonangeli I checked the failing tests. As I feared, this change has an impact on the old GWT Stunner editors, which are PF3-based. Please notice the following screenshot: <img width="1170" alt="Screenshot 2025-01-17 at 13 03 10" src="https://github.com/user-attachments/assets/5cdc4195-5c8b-4572-8cdd-3f4b164f3294"; /> On the left, you can see the version without your changes. On the right, is the version with the PF5 migration. You may notice there are some minor style changes, I guess those changes may have effects on the failing test, but I still didn't check that. The reason for this behavior is that in DMN Editor we nested a React component (the table) that is affected by your changes, in a GWT Editor based on PF3. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
