jomarko commented on code in PR #2860:
URL:
https://github.com/apache/incubator-kie-tools/pull/2860#discussion_r1924858176
##########
packages/scesim-editor/tests-e2e/__fixtures__/editor.ts:
##########
@@ -61,6 +61,6 @@ export class Editor {
}
public get() {
- return this.page.getByTestId("test-scenario-editor");
+ return this.page.getByTestId("kie-tools--scesim-editor--container");
Review Comment:
This is my mistake. I am sorry. Looking on the rest of the codebase, I think
the value we should use should be probably something like:
`kie-scesim-editor--container` or `kie-scesim-editor-container` or
`kie-scesim-editor`
##########
packages/scesim-editor/src/TestScenarioEditor.tsx:
##########
@@ -395,7 +396,7 @@ export const TestScenarioEditorInternal = ({
console.trace("[TestScenarioEditorInternal] File Status: " +
TestScenarioFileStatus[scesimFileStatus]);
return (
- <div ref={testScenarioEditorRootElementRef}>
+ <div ref={testScenarioEditorRootElementRef}
data-testid="kie-tools--scesim-editor--container">
Review Comment:
This is my mistake. I am sorry. Looking on the rest of the codebase, I think
the value we should use should be probably something like:
`kie-scesim-editor--container` or `kie-scesim-editor-container` or
`kie-scesim-editor`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
