jomarko commented on PR #2863: URL: https://github.com/apache/incubator-kie-tools/pull/2863#issuecomment-2606670129
@LightGuard hi, I am not author of the codebase we speak about, so my comment may be wrong, however here is my opinion. ### `WorkspaceOrigin` I understand this part of code as holder of data that we want to display later. Maybe this code can be improved somehow, not sure. I think to decide it, we need to get an answer for the paragraph below. NOTE: I didn't check the relation of `WorkspaceOrigin` and `workspace.descriptor.origin.url` I just trust you there is such. ### `UI` I see we use `workspace.descriptor.origin.url` in four places. Right? - `VsCodeDropdownMenu` - `GitIntegrationAlerts` - `GitIntegrationContextProvider` - `EditorToolbar` If each of these four places has **different** logic, how to display `workspace.descriptor.origin.url` (e.g. somewhere we want `.git` suffix, somewhere we don't, somewhere we want protocol prefix, somewhere we don't ....) then I do not think there is an easy way to update `WorkspaceOrigin` to satisfy all usages of it. If each of these four places has **same** logic, or should have same logic, how to display `workspace.descriptor.origin.url`, then probably it is worth to update `WorkspaceOrigin`. From the existing code it seems on a lot of `UI` places we remove the `.git` suffix, however, probably @thiagoelg could help with the answer, if that should be like that across all `UI` codebase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
