gitgabrio opened a new pull request, #6231: URL: https://github.com/apache/incubator-kie-drools/pull/6231
Fixes https://github.com/apache/incubator-kie-issues/issues/1744 This PR: 1. implement conversion of equal unary test to range (e.g. =10 -> [10 ..10]] 2. disable one test that currently break with the new implementation, due to apparent unconsistence of DMN specs/implementation 3. add a test to verify unarytest/range comparison This is the diff of TCK test before and after this PR: main > "compliance-level-3/0068-feel-equality","0068-feel-equality-test-01","range_010","ERROR","FAILURE: 'range_010' expected='false' but found='null'" > "compliance-level-3/0068-feel-equality","0068-feel-equality-test-01","range_011","ERROR","FAILURE: 'range_011' expected='true' but found='null'" PR < "compliance-level-3/0068-feel-equality","0068-feel-equality-test-01","range_010","ERROR","FAILURE: 'range_010' expected='false' but found='true'" < "compliance-level-3/0068-feel-equality","0068-feel-equality-test-01","range_011","SUCCESS","" As discussed in issue, some tests seems to compare the syntax, and not the actual value, so those won't be fixed by this PR. <details> <summary> How to replicate CI configuration locally? </summary> Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use [build-chain tool](https://github.com/kiegroup/github-action-build-chain) to handle cross repository builds and be sure that we always use latest version of the code for each repository. [build-chain tool](https://github.com/kiegroup/github-action-build-chain) is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See [local execution](https://github.com/kiegroup/github-action-build-chain#local-execution) details to get more information about it. </details> <details> <summary> How to retest this PR or trigger a specific build: </summary> - for <b>pull request and downstream checks</b> - Push a new commit to the PR. An empty commit would be enough. - for a <b>full downstream build</b> - for <b>github actions</b> job: add the label `run_fdb` - for <b>Jenkins PR check only</b> - If you are an ASF committer for KIE podling, login to Jenkins (https://ci-builds.apache.org/job/KIE/job/drools/), go to the specific PR job, and click on `Build Now` button. </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
