gmunozfe commented on code in PR #2051:
URL:
https://github.com/apache/incubator-kie-kogito-examples/pull/2051#discussion_r1932333512
##########
kogito-quarkus-examples/kogito-travel-agency/extended/docker-compose/docker-compose.yml:
##########
@@ -110,26 +122,27 @@ services:
data-index:
container_name: data-index
- image: quay.io/kiegroup/kogito-data-index-infinispan:10.0
+ image:
docker.io/apache/incubator-kie-kogito-data-index-postgresql:${KOGITO_VERSION}
Review Comment:
Avoid dockerhub pulls, as Docker Hub usage now falls under Docker's modified
licensing terms and has limits.
```suggestion
image:
mirror.gcr.io/apache/incubator-kie-kogito-data-index-postgresql:${KOGITO_VERSION}
```
##########
kogito-quarkus-examples/kogito-travel-agency/extended/docker-compose/docker-compose.yml:
##########
@@ -110,26 +122,27 @@ services:
data-index:
container_name: data-index
- image: quay.io/kiegroup/kogito-data-index-infinispan:10.0
+ image:
docker.io/apache/incubator-kie-kogito-data-index-postgresql:${KOGITO_VERSION}
ports:
- "8180:8080"
depends_on:
kafka:
condition: service_started
- infinispan:
+ postgres:
condition: service_healthy
volumes:
- ./target/protobuf:/home/kogito/data/protobufs/
environment:
- QUARKUS_INFINISPAN_CLIENT_HOSTS: infinispan:11222
- QUARKUS_INFINISPAN_CLIENT_USE_AUTH: "false"
- QUARKUS_HTTP_CORS_ORIGINS: "/.*/"
+ QUARKUS_DATASOURCE_JDBC_URL: "jdbc:postgresql://postgres:5432/kogito"
+ QUARKUS_DATASOURCE_USERNAME: kogito-user
+ QUARKUS_DATASOURCE_PASSWORD: kogito-pass
KAFKA_BOOTSTRAP_SERVERS: kafka:29092
- KOGITO_DATA_INDEX_PROPS:
-Dkogito.protobuf.folder=/home/kogito/data/protobufs/
+ QUARKUS_HTTP_CORS_ORIGINS: "/.*/"
+ KOGITO_DATA_INDEX_PROPS:
-Dquarkus.hibernate-orm.database.generation=update
management-console:
container_name: management-console
- image: quay.io/kiegroup/kogito-management-console:10.0
+ image:
docker.io/apache/incubator-kie-kogito-management-console:${KOGITO_VERSION}
Review Comment:
Same
```suggestion
image:
mirror.gcr.io/apache/incubator-kie-kogito-management-console:${KOGITO_VERSION}
```
##########
kogito-quarkus-examples/ocp-tryout/kogito-jobs-service/kogito-jobs-service.sh:
##########
@@ -28,7 +28,7 @@ if [ "${action}" == "uninstall" ]; then
elif [ "${action}" == "install" ]; then
echo "*** installing jobs service"
- oc new-app quay.io/kiegroup/kogito-jobs-service-${type}:10.0
+ oc new-app
docker.io/apache/incubator-kie-kogito-jobs-service-${type}:${KOGITO_VERSION} -n
$(getProjectName) $(dryRun "NewApp")
Review Comment:
same
```suggestion
oc new-app
mirror.gcr.io/apache/incubator-kie-kogito-jobs-service-${type}:${KOGITO_VERSION}
-n $(getProjectName) $(dryRun "NewApp")
```
##########
kogito-quarkus-examples/ocp-tryout/kogito-management-console/kogito-management-console.sh:
##########
@@ -36,7 +36,7 @@ elif [ "${action}" == "install" ]; then
oc create configmap kogito-management-config --from-file=../testapp/svg -o
yaml --dry-run=client | \
oc label -f- --dry-run=client -o yaml --local=true
app=kogito-management-console | \
oc apply -f- -n $(getProjectName) $(dryRun)
- oc new-app quay.io/kiegroup/kogito-management-console:10.0
+ oc new-app docker.io/apache/incubator-kie-kogito-management-console:10.0
Review Comment:
Same
```suggestion
oc new-app
mirror.gcr.io/apache/incubator-kie-kogito-management-console:10.0
```
##########
serverless-workflow-examples/serverless-workflow-callback-quarkus/docker-compose/docker-compose.yml:
##########
@@ -83,7 +83,7 @@ services:
data-index:
container_name: data-index
- image: quay.io/kiegroup/kogito-data-index-postgresql-nightly:10.0
+ image: docker.io/apache/incubator-kie-kogito-data-index-postgresql:main
Review Comment:
Same
```suggestion
image:
mirror.gcr.io/apache/incubator-kie-kogito-data-index-postgresql:main
```
##########
kogito-quarkus-examples/process-usertasks-timer-quarkus-with-console/docker-compose/docker-compose-postgresql.yml:
##########
@@ -125,7 +125,7 @@ services:
jobs-service:
container_name: jobs-service
- image: quay.io/kiegroup/kogito-jobs-service-postgresql:10.0
+ image: docker.io/apache/incubator-kie-kogito-jobs-service-postgresql:10.0.0
Review Comment:
Same
```suggestion
image:
mirror.gcr.io/apache/incubator-kie-kogito-jobs-service-postgresql:10.0.0
```
##########
serverless-workflow-examples/serverless-workflow-newsletter-subscription/kubernetes/data-index-services.yml:
##########
@@ -31,31 +31,31 @@ spec:
targetPort: 8080
selector:
app.kubernetes.io/name: data-index-service-postgresql
- app.kubernetes.io/version: 999-SNAPSHOT
+ app.kubernetes.io/version: 10.0.0
type: ClusterIP
---
apiVersion: apps/v1
kind: Deployment
metadata:
labels:
app.kubernetes.io/name: data-index-service-postgresql
- app.kubernetes.io/version: 999-SNAPSHOT
+ app.kubernetes.io/version: 10.0.0
name: data-index-service-postgresql
spec:
replicas: 1
selector:
matchLabels:
app.kubernetes.io/name: data-index-service-postgresql
- app.kubernetes.io/version: 999-SNAPSHOT
+ app.kubernetes.io/version: 10.0.0
template:
metadata:
labels:
app.kubernetes.io/name: data-index-service-postgresql
- app.kubernetes.io/version: 999-SNAPSHOT
+ app.kubernetes.io/version: 10.0.0
spec:
containers:
- name: data-index-service-postgresql
- image: quay.io/kiegroup/kogito-data-index-postgresql-nightly:10.0
+ image:
docker.io/apache/incubator-kie-kogito-data-index-postgresql:main
Review Comment:
Same
```suggestion
image:
mirror.gcr.io/apache/incubator-kie-kogito-data-index-postgresql:main
```
##########
serverless-workflow-examples/serverless-workflow-newsletter-subscription/kubernetes/supporting-services.yml:
##########
@@ -138,31 +138,31 @@ spec:
targetPort: 8080
selector:
app.kubernetes.io/name: jobs-service-postgresql
- app.kubernetes.io/version: 999-SNAPSHOT
+ app.kubernetes.io/version: 10.0.0
type: ClusterIP
---
apiVersion: apps/v1
kind: Deployment
metadata:
labels:
app.kubernetes.io/name: jobs-service-postgresql
- app.kubernetes.io/version: 999-SNAPSHOT
+ app.kubernetes.io/version: 10.0.0
name: jobs-service-postgresql
spec:
replicas: 1
selector:
matchLabels:
app.kubernetes.io/name: jobs-service-postgresql
- app.kubernetes.io/version: 999-SNAPSHOT
+ app.kubernetes.io/version: 10.0.0
template:
metadata:
labels:
app.kubernetes.io/name: jobs-service-postgresql
- app.kubernetes.io/version: 999-SNAPSHOT
+ app.kubernetes.io/version: 10.0.0
spec:
containers:
- name: jobs-service-postgresql
- image: quay.io/kiegroup/kogito-jobs-service-postgresql-nightly:10.0
+ image:
docker.io/apache/incubator-kie-kogito-jobs-service-postgresql:main
Review Comment:
Same
```suggestion
image:
mirror.gcr.io/apache/incubator-kie-kogito-jobs-service-postgresql:main
```
##########
kogito-quarkus-examples/ocp-tryout/kogito-management-console/kogito-management-console.sh:
##########
@@ -36,7 +36,7 @@ elif [ "${action}" == "install" ]; then
oc create configmap kogito-management-config --from-file=../testapp/svg -o
yaml --dry-run=client | \
oc label -f- --dry-run=client -o yaml --local=true
app=kogito-management-console | \
oc apply -f- -n $(getProjectName) $(dryRun)
- oc new-app quay.io/kiegroup/kogito-management-console:10.0
+ oc new-app docker.io/apache/incubator-kie-kogito-management-console:10.0
Review Comment:
Are you using a hardcoded version here for any purpose?
##########
kogito-quarkus-examples/process-usertasks-timer-quarkus-with-console/docker-compose/docker-compose-postgresql.yml:
##########
@@ -105,7 +105,7 @@ services:
data-index:
container_name: data-index
- image: quay.io/kiegroup/kogito-data-index-postgresql:10.0
+ image: docker.io/apache/incubator-kie-kogito-data-index-postgresql:10.0
Review Comment:
Same
```suggestion
image:
mirror.gcr.io/apache/incubator-kie-kogito-data-index-postgresql:10.0
```
##########
.ci/jenkins/Jenkinsfile.setup-branch:
##########
@@ -137,7 +137,7 @@ pipeline {
String[] versionSplit = getKogitoVersion().split("\\.")
String reducedTag = "${versionSplit[0]}.${versionSplit[1]}"
sh """
- grep -r -l --exclude-dir=.ci 'quay.io/kiegroup' |
xargs -I{} sed -i
's|quay.io/kiegroup/\\(.*\\):.*|quay.io/kiegroup/\\1:${reducedTag}|g' {}
+ grep -r -l --exclude-dir=.ci
'docker.io/apache/incubator-kie-' | xargs -I{} sed -i
's|docker.io/apache/incubator-kie-\\(.*\\):.*|docker.io/apache/incubator-kie-\\1:${reducedTag}|g'
{}
Review Comment:
Avoid dockerhub pulls, as Docker Hub usage now falls under Docker's modified
licensing terms and has limits.
```suggestion
grep -r -l --exclude-dir=.ci
'mirror.gcr.io/apache/incubator-kie-' | xargs -I{} sed -i
's|mirror.gcr.io/apache/incubator-kie-\\(.*\\):.*|mirror.gcr.io/apache/incubator-kie-\\1:${reducedTag}|g'
{}
```
##########
kogito-quarkus-examples/kogito-travel-agency/extended/docker-compose/docker-compose.yml:
##########
@@ -146,7 +159,7 @@ services:
task-console:
container_name: task-console
- image: quay.io/kiegroup/kogito-task-console:10.0
+ image: docker.io/apache/incubator-kie-kogito-task-console:${KOGITO_VERSION}
Review Comment:
Same
```suggestion
image:
mirror.gcr.io/apache/incubator-kie-kogito-task-console:${KOGITO_VERSION}
```
##########
kogito-quarkus-examples/ocp-tryout/kogito-task-console/kogito-task-console.sh:
##########
@@ -27,11 +28,11 @@ if [ "${action}" == "uninstall" ]; then
elif [ "${action}" == "install" ]; then
echo "*** installing task console"
- oc new-app quay.io/kiegroup/kogito-task-console:10.0
+ oc new-app
docker.io/apache/incubator-kie-kogito-task-console:${KOGITO_VERSION} -n
$(getProjectName) $(dryRun "NewApp")
Review Comment:
Same
```suggestion
oc new-app
mirror.gcr.io/apache/incubator-kie-kogito-task-console:${KOGITO_VERSION} -n
$(getProjectName) $(dryRun "NewApp")
```
##########
kogito-quarkus-examples/ocp-tryout/kogito-data-index/kogito-data-index.sh:
##########
@@ -37,7 +37,7 @@ elif [ "${action}" == "install" ]; then
oc create configmap data-index-config --from-file=../testapp/protobuf -o
yaml --dry-run=client | \
oc label -f- --dry-run=client -o yaml --local=true
app=kogito-data-index-"${type}" | \
oc apply -f- -n $(getProjectName) $(dryRun)
- oc new-app quay.io/kiegroup/kogito-data-index-"${type}":10.0
+ oc new-app
docker.io/apache/incubator-kie-kogito-data-index-"${type}":"${KOGITO_VERSION}"
-n $(getProjectName) $(dryRun "NewApp")
Review Comment:
same
```suggestion
oc new-app
mirror.gcr.io/apache/incubator-kie-kogito-data-index-"${type}":"${KOGITO_VERSION}"
-n $(getProjectName) $(dryRun "NewApp")
```
##########
kogito-quarkus-examples/process-usertasks-timer-quarkus-with-console/docker-compose/docker-compose-postgresql.yml:
##########
@@ -167,7 +167,7 @@ services:
task-console:
container_name: task-console
- image: quay.io/kiegroup/kogito-task-console:10.0
+ image: docker.io/apache/incubator-kie-kogito-task-console:${KOGITO_VERSION}
Review Comment:
Same
```suggestion
image:
mirror.gcr.io/apache/incubator-kie-kogito-task-console:${KOGITO_VERSION}
```
##########
kogito-quarkus-examples/process-usertasks-timer-quarkus-with-console/docker-compose/docker-compose-postgresql.yml:
##########
@@ -146,7 +146,7 @@ services:
management-console:
container_name: management-console
- image: quay.io/kiegroup/kogito-management-console:10.0
+ image:
docker.io/apache/incubator-kie-kogito-management-console:${KOGITO_VERSION}
Review Comment:
Same
```suggestion
image:
mirror.gcr.io/apache/incubator-kie-kogito-management-console:${KOGITO_VERSION}
```
##########
serverless-workflow-examples/serverless-workflow-data-index-persistence-addon-quarkus/docker-compose/docker-compose.yml:
##########
@@ -30,7 +30,7 @@ services:
data-index:
container_name: data-index
- image: quay.io/kiegroup/kogito-data-index-postgresql-nightly:10.0
+ image: docker.io/apache/incubator-kie-kogito-data-index-postgresql:main
Review Comment:
Same
```suggestion
image:
mirror.gcr.io/apache/incubator-kie-kogito-data-index-postgresql:main
```
##########
serverless-workflow-examples/serverless-workflow-data-index-quarkus/docker-compose/docker-compose-with-data-index.yml:
##########
@@ -49,7 +49,7 @@ services:
data-index:
container_name: data-index
- image: quay.io/kiegroup/kogito-data-index-postgresql-nightly:10.0
+ image: docker.io/apache/incubator-kie-kogito-data-index-postgresql:main
Review Comment:
Same
```suggestion
image:
mirror.gcr.io/apache/incubator-kie-kogito-data-index-postgresql:main
```
##########
serverless-workflow-examples/serverless-workflow-timeouts-showcase-extended/kubernetes/jobs-service-postgresql.yml:
##########
@@ -72,16 +72,16 @@ spec:
selector:
matchLabels:
app.kubernetes.io/name: jobs-service-postgresql
- app.kubernetes.io/version: 999-SNAPSHOT
+ app.kubernetes.io/version: 10.0.0
template:
metadata:
labels:
app.kubernetes.io/name: jobs-service-postgresql
- app.kubernetes.io/version: 999-SNAPSHOT
+ app.kubernetes.io/version: 10.0.0
spec:
containers:
- name: jobs-service-postgresql
- image: quay.io/kiegroup/kogito-jobs-service-postgresql-nightly:10.0
+ image:
docker.io/apache/incubator-kie-kogito-jobs-service-postgresql-nightly:10.0.0
Review Comment:
Same
```suggestion
image:
mirror.gcr.io/apache/incubator-kie-kogito-jobs-service-postgresql-nightly:10.0.0
```
##########
serverless-workflow-examples/serverless-workflow-loanbroker-showcase/kubernetes/jobs-service-postgresql.yml:
##########
@@ -52,32 +52,32 @@ spec:
targetPort: 8080
selector:
app.kubernetes.io/name: jobs-service-postgresql
- app.kubernetes.io/version: 999-SNAPSHOT
+ app.kubernetes.io/version: 10.0.0
type: ClusterIP
---
apiVersion: apps/v1
kind: Deployment
metadata:
labels:
app.kubernetes.io/name: jobs-service-postgresql
- app.kubernetes.io/version: 999-SNAPSHOT
+ app.kubernetes.io/version: 10.0.0
name: jobs-service-postgresql
namespace: loanbroker-example
spec:
replicas: 1
selector:
matchLabels:
app.kubernetes.io/name: jobs-service-postgresql
- app.kubernetes.io/version: 999-SNAPSHOT
+ app.kubernetes.io/version: 10.0.0
template:
metadata:
labels:
app.kubernetes.io/name: jobs-service-postgresql
- app.kubernetes.io/version: 999-SNAPSHOT
+ app.kubernetes.io/version: 10.0.0
spec:
containers:
- name: jobs-service-postgresql
- image: quay.io/kiegroup/kogito-jobs-service-postgresql-nightly:10.0
+ image:
docker.io/apache/incubator-kie-kogito-jobs-service-postgresql:main
Review Comment:
Same
```suggestion
image:
mirror.gcr.io/apache/incubator-kie-kogito-jobs-service-postgresql:main
```
##########
serverless-workflow-examples/serverless-workflow-timeouts-showcase-extended/kubernetes/data-index-service-postgresql.yml:
##########
@@ -31,31 +31,31 @@ spec:
targetPort: 8080
selector:
app.kubernetes.io/name: data-index-service-postgresql
- app.kubernetes.io/version: 999-SNAPSHOT
+ app.kubernetes.io/version: 10.0.0
type: ClusterIP
---
apiVersion: apps/v1
kind: Deployment
metadata:
labels:
app.kubernetes.io/name: data-index-service-postgresql
- app.kubernetes.io/version: 999-SNAPSHOT
+ app.kubernetes.io/version: 10.0.0
name: data-index-service-postgresql
spec:
replicas: 1
selector:
matchLabels:
app.kubernetes.io/name: data-index-service-postgresql
- app.kubernetes.io/version: 999-SNAPSHOT
+ app.kubernetes.io/version: 10.0.0
template:
metadata:
labels:
app.kubernetes.io/name: data-index-service-postgresql
- app.kubernetes.io/version: 999-SNAPSHOT
+ app.kubernetes.io/version: 10.0.0
spec:
containers:
- name: data-index-service-postgresql
- image: quay.io/kiegroup/kogito-data-index-postgresql-nightly:10.0
+ image:
docker.io/apache/incubator-kie-kogito-data-index-postgresql-nightly:10.0.0
Review Comment:
Same
```suggestion
image:
mirror.gcr.io/apache/incubator-kie-kogito-data-index-postgresql-nightly:10.0.0
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
