jomarko commented on PR #2849: URL: https://github.com/apache/incubator-kie-tools/pull/2849#issuecomment-2621080361
@tiagobento @kbowers-ibm @ljmotta or anyone else, I will write down my analysis of the problem https://github.com/apache/incubator-kie-tools/pull/2849#issuecomment-2618631310, it is the thing that runner output columns are not resizable, there is missing the resize handler. It was introduced by changes regarding `readOnly` mode https://github.com/apache/incubator-kie-tools/pull/2538/files#diff-ab6fc87d76da643cd7a7f3cd903f077619837939303defc50b2d0e208a2d5ca5. The missing resize handler in dmn runner outputs columns is a problem because of this two things #### Too long header text Makes header unreadable and in combination with new arrow up button quite 'messy'.  #### Too long data text Makes data unreadable  So here are some options I see. Please comment them or bring other so we can decide what option is the best. ### 01 'Weak' ReadOnly mode We could change the `isReadOnly` of `StandaloneBeeTable` to be slightly 'weak'. I mean, we could allow to display resize handler even if `isReadOnly` is set to `true` **Pros** - it would fix the issue of unreadable header or data if the text is too long **Cons** - it decreases the level 'readonly' feeling. for example, readonly in google spreadsheets does not allow to resize column, if I am not wrong - it affects more places, not just dmn runner outputs. for example opened included decision node ### 02 'allowResizing' property We could introduce additional property `allowResizing` next to `isReadOnly` in `StandaloneBeeTable` **Pros** - we would be able to fix just the dmn runner outputs scenario without an effect on other `StandaloneBeeTable` usages **Cons** - it increases `StandaloneBeeTable` props complexity ### 03 'width' computation We could reuse the column width computation for given text as we have here: https://github.com/apache/incubator-kie-tools/blob/main/packages/dmn-editor/src/boxedExpressions/getDefaultColumnWidth.tsx directly in `DmnRunnerOutputsTable` when we define `beeTableColumns` variable. **Pros** - We do not need to touch `StandaloneBeeTable` code - We keep strong readonly 'feeling' on all `StandaloneBeeTable` usages **Cons** - we fix only the scenario of a long text in the header, if a long text is in data cell, it still remains unreadable -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
