kbowers-ibm commented on code in PR #2834:
URL:
https://github.com/apache/incubator-kie-tools/pull/2834#discussion_r1935566474
##########
packages/dmn-editor/tests-e2e/checkDecisionTableCellsDataType.spec.ts:
##########
@@ -673,7 +665,7 @@ test.describe("Decision Table - Cells Data Type -
Constraint", () => {
await
expect(beePropertiesPanel.decisionTableOutputHeader.getExpressionDataType()).toHaveValue(
/^\s*rangeType\s$/i
);
- await
expect(beePropertiesPanel.decisionTableOutputHeader.getColumnDataType()).toHaveValue(/^\s*rangeType\s$/i);
+ await
expect(beePropertiesPanel.decisionTableOutputHeader.getDataType()).toHaveValue(/^\s*rangeType\s$/i);
Review Comment:
This line can just be deleted instead of changed from
getColumnDataType to getDataType.
It's preceded by
```
await
expect(beePropertiesPanel.decisionTableOutputHeader.getExpressionDataType()).toHaveValue(
/^\s*rangeType\s$/i
);
```
And due to the nature of the 2 functions it's just checking the same thing
twice in a row.
This happens in multiple test cases, so please update all of them
accordingly! :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org
For additional commands, e-mail: commits-h...@kie.apache.org
