jomarko commented on PR #2868: URL: https://github.com/apache/incubator-kie-tools/pull/2868#issuecomment-2630754239
Hi @tiagobento , ### 01 hover There is no behavior for hovering. We didn't define it in the feature definition phase. What is your suggestion for the 'hover' situation? ### 02 alignment Should be fixed. I didn't record a video as it is enough to start playbook as `pnpm -F @kie-tools/dmn-editor start` ### 03 Border this is the most problematic as the current border of nodes has width `1.5px`. From reading some [internet threads](https://stackoverflow.com/questions/9080633/can-a-css-pixel-be-a-fraction), it seems as not ideal to use fractions and pixels together. I tried to margin my pseudo element with: 1. `1px` 2. `1.5px` 3. `2px` however there is some rounding and it is never correct result. #### 1px  #### 1.5px, 2px for both the same result, 1.5 is rounded to 2  What I could do is to change `NodeStyle.ts` where we define default stroke width `export const DEFAULT_NODE_STROKE_WIDTH = 1.5;`, however any change we would do there (1px or 2px) would affect all tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
