wmedvede commented on PR #2896:
URL:
https://github.com/apache/incubator-kie-tools/pull/2896#issuecomment-2639081098
Hi @fantonangeli , it looks like I came late to the review of this one, but
let me add a couple of comments.
Regarding the adding of
**addons-quarkus-jobs-service-embedded:${KOGITO_VERSION},org.kie:kogito-addons-quarkus-data-index-inmemory:${KOGITO_VERSION}**,
keep in mind that these two are ephemeral. I'd, if the Pod that locates the
application is restarted for whatever reason, the information presented for
example by the DI will vanish.
This is not necessarily bad, just depends on the scope of the information
that is stored by the application. IDK to be honest what is exactly the case
for this particular app.
Then, with these two extensions added, this one is not needed:
**addons-quarkus-jobs-knative-eventing:${KOGITO_VERSION}**
Great work on fixing this app, many thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
