thiagoelg commented on code in PR #2901:
URL:
https://github.com/apache/incubator-kie-tools/pull/2901#discussion_r1951057124
##########
packages/image-env-to-json/package.json:
##########
@@ -14,32 +14,31 @@
},
"main": "dist/index.js",
"scripts": {
- "build:dev": "rimraf -rf dist && webpack --env dev && pnpm
build:standalone:all",
- "build:prod": "pnpm lint && rimraf -rf dist && webpack && pnpm
build:standalone:all",
- "build:standalone": "run-script-os",
- "build:standalone:all": "pnpm build:standalone:darwin && pnpm
build:standalone:linux && pnpm build:standalone:win32",
- "build:standalone:darwin": "pkg dist/index.js -t node18-macos-x64 -o
dist/macos/image-env-to-json-standalone",
- "build:standalone:linux": "pkg dist/index.js -t node18-linux-x64 -o
dist/linux/image-env-to-json-standalone",
- "build:standalone:win32": "pkg dist/index.js -t node18-win-x64 -o
dist/win/image-env-to-json-standalone",
- "lint": "run-script-if --bool \"$(build-env linters.run)\" --then
\"kie-tools--eslint ./src\""
- },
- "dependencies": {
- "commander": "^8.3.0"
+ "build": "run-script-os",
+ "build:darwin": "pnpm setup:env make build-darwin",
+ "build:darwin:amd": "pnpm setup:env make build-darwin-amd64",
+ "build:darwin:arm": "pnpm setup:env make build-darwin-arm64",
+ "build:dev": "rimraf -rf dist && pnpm build",
+ "build:linux": "pnpm setup:env make build-linux",
+ "build:linux:amd": "pnpm setup:env make build-linux-amd64",
+ "build:linux:arm": "pnpm setup:env make build-linux-arm64",
+ "build:prod": "rimraf -rf dist && run-script-os && pnpm test",
+ "build:prod:darwin": "rimraf dist && pnpm setup:env make build-all",
+ "build:prod:linux": "rimraf dist && pnpm setup:env make build-all",
+ "build:prod:win32": "rimraf dist && pnpm setup:env:win32 make build-all",
+ "build:win32": "pnpm setup:env:win32 make build-win",
+ "build:win32:amd": "pnpm setup:env:win32 make build-win-amd64",
+ "build:win32:arm": "pnpm setup:env:win32 make build-win-arm64",
Review Comment:
I think we should build all binaries every time (on build:dev and
build:prod). It should be quick, and we can avoid issues where, for example, we
test the binary in a macOS ARM environment but then run it inside a Linux x64
container.
It would also simplify this list of scripts in the package.json.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
