tkobayas commented on code in PR #6251:
URL:
https://github.com/apache/incubator-kie-drools/pull/6251#discussion_r1952198271
##########
drools-core/src/main/java/org/drools/core/common/PhreakPropagationContext.java:
##########
@@ -233,7 +233,7 @@ public PropagationContext
adaptModificationMaskForObjectType(ObjectType type, Re
Class<?> classType = classObjectType.getClassType();
String pkgName = classType.getPackage().getName();
- if (classType == modifiedClass || "java.lang".equals(pkgName) ||
!(classType.isInterface() || modifiedClass.isInterface())) {
+ if (classType == modifiedClass || "java.lang".equals(pkgName)) {
Review Comment:
The condition `!(classType.isInterface() || modifiedClass.isInterface())`
allows the mask adaptation only for cases with Interface involved. This was
introduced by
https://github.com/apache/incubator-kie-drools/commit/6d2840d9ac5e322b9df8b29355d5e5f5d1786004
But I think it's fine to allow for cases where both are classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
