josedee commented on code in PR #3843:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/3843#discussion_r1956408466
##########
addons/common/flyway/src/main/java/org/kie/flyway/initializer/KieFlywayInitializer.java:
##########
@@ -97,11 +89,11 @@ private void runFlyway(KieFlywayModuleConfig config) {
return;
}
- String[] locations = config.getDBScriptLocations(databaseType);
+ String[] locations =
config.getDBScriptLocations(databaseInfo.getNormalizedName());
if (Objects.isNull(locations)) {
- LOGGER.warn("Cannot run Flyway migration for module `{}`, cannot
find SQL Script locations for db `{}`", config.getModule(), databaseType);
- throw new KieFlywayException("Cannot run Flyway migration for
module `" + config.getModule() + "`, cannot find SQL Script locations for db `"
+ databaseType + "`");
+ LOGGER.warn("Cannot run Flyway migration for module `{}`, cannot
find SQL Script locations for db `{}`", config.getModule(), databaseInfo);
+ throw new KieFlywayException("Cannot run Flyway migration for
module `" + config.getModule() + "`, cannot find SQL Script locations for db `"
+ databaseInfo + "`");
Review Comment:
Nicely done @pefernan.
Just wondering if we need to override `toString()` to print the database info
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
