RishiRajAnand commented on code in PR #6131:
URL:
https://github.com/apache/incubator-kie-drools/pull/6131#discussion_r1958086477
##########
drools-reliability/drools-reliability-tests/src/test/java/org/drools/reliability/test/EmbeddedStorageManagerTest.java:
##########
@@ -63,54 +61,29 @@ static boolean isEmbeddedInfinispan() {
void removeAllSessionCaches_shouldLeaveNonSessionCache() {
((InfinispanStorageManager)
StorageManagerFactory.get().getStorageManager()).setEmbeddedCacheManager(new
FakeCacheManager());
-
assertThat(StorageManagerFactory.get().getStorageManager().getStorageNames()).containsExactlyInAnyOrder(
- SESSION_STORAGE_PREFIX + "0_" + "epDefault",
SESSION_STORAGE_PREFIX + "1_" + "epDefault", "METADATA_0");
-
StorageManagerFactory.get().getStorageManager().removeAllSessionStorages();
-
assertThat(StorageManagerFactory.get().getStorageManager().getStorageNames()).containsExactly("METADATA_0");
+
assertThat(StorageManagerFactory.get().getStorageManager().getStorageNames()).contains("METADATA_0");
}
Review Comment:
@pibizza thanks for catching this. I checked this test case and found that
it contains only METADATA_0. I remember while working on the upgrade there was
something else that was part of the list too, initially I upgraded to
Infinispan 15.0.8.final and lastly to 15.0.11.final as quarkus released new LTS
in the meantime. So, something may have changed in between. I think we can
revert it to previous changes.
@tkobayas Are you working on EmbeddedStorageManagerTest as you mentioned
[earlier](https://github.com/apache/incubator-kie-drools/pull/6131#pullrequestreview-2557965768).
If you are, could you please include these changes, else i will create a
separate PR ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
