yesamer commented on code in PR #2887:
URL:
https://github.com/apache/incubator-kie-tools/pull/2887#discussion_r1959428998
##########
packages/scesim-editor/src/creation/TestScenarioCreationPanel.tsx:
##########
@@ -99,9 +198,30 @@ function TestScenarioCreationPanel() {
</FormGroup>
{assetType === "DMN" && (
<>
- <FormGroup label={i18n.creationPanel.dmnGroup} isRequired>
- <FormSelect id="dmn-select" name="dmn-select" value={""}
isDisabled>
- <FormSelectOption isDisabled={true} key={0} value={""}
label={i18n.creationPanel.dmnNoChoice} />
+ <FormGroup isRequired label={i18n.creationPanel.dmnGroup}>
+ <FormSelect
+ id="dmn-select"
+ name="dmn-select"
+ onChange={(dmnModelPathRelativeToThisScesim) => {
+ if (typeof dmnModelPathRelativeToThisScesim !== "string") {
Review Comment:
I agree is not necessary at all. Removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
