gitgabrio commented on issue #1790: URL: https://github.com/apache/incubator-kie-issues/issues/1790#issuecomment-2667828620
@Abhitocode Please look at https://github.com/apache/incubator-kie-kogito-runtimes/pull/3842 and related PRs. Critical points 1. avoid creating "global scope" variables (e.g. `spring.main.allow-bean-definition-overriding=true` ) without coordination of other teams (decisions/rules/etc) because it would lead up to inconsistencies and issues for our users, that may use all our engines, and not just one 2. using BOTH declarative (i.e. application.properties property) and programmatic (i.e. CDI annotation) approach is a contradiction and a code smell 3. we should avoid / stop create duplication for different frameworks 4. in our context, the simplest solution is to a. use the property to identify which class has to be loaded instead of the default one, and in which case (e.g. kogito.workflow.businesscalendar.override=FQDN) b. at codegen, if such property is present, modify the generated class to load the overriding one To enforce the concept: we have to provide a consistent user-experience for both final users and, eventually, contributors, avoiding all possible kind of duplication, if not absolutely needed (and in this case it is not). @baldimir @yesamer @martinweiler @pefernan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
