Kusuma04-dev commented on PR #2912:
URL: 
https://github.com/apache/incubator-kie-tools/pull/2912#issuecomment-2668544592

   > @Kusuma04-dev Hi, thank you for the PR. I think from now one users will be 
able to add rows even to a table, that has zero rows/rules in the xml.
   > 
   > However, I would like to share one idea/proposal, that from my point of 
view would make more clear difference between no data state vs some data state.
   > 
   > ### Currently we have
   > #### 0 rows just opened
   > ![Screenshot 2025-02-19 
095435](https://private-user-images.githubusercontent.com/8044780/414638563-95994ad1-ceb6-4b93-94e1-ae500fa78c47.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk5NTk3ODgsIm5iZiI6MTczOTk1OTQ4OCwicGF0aCI6Ii84MDQ0NzgwLzQxNDYzODU2My05NTk5NGFkMS1jZWI2LTRiOTMtOTRlMS1hZTUwMGZhNzhjNDcucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxOSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTlUMTAwNDQ4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NDU0MjVjNzZjYzJmZDI2NDlkZTBlYzg0NGI5ZGZmOWI2YjUyMzRiY2QxZWUxYTEzNDM5ZmUwZTljZTEzYzE3NSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.UgPvcXG4Zbg2Yf_O1KJny6oscuhFjFad_eNvt-_yMTg)
   > 
   > #### 0 rows transformed to one row
   > ![Screenshot 2025-02-19 
095445](https://private-user-images.githubusercontent.com/8044780/414639002-e0e0ef3d-8ab4-47c9-af78-f2fc8929ad63.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk5NTk3ODgsIm5iZiI6MTczOTk1OTQ4OCwicGF0aCI6Ii84MDQ0NzgwLzQxNDYzOTAwMi1lMGUwZWYzZC04YWI0LTQ3YzktYWY3OC1mMmZjODkyOWFkNjMucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxOSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTlUMTAwNDQ4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZWQ5NDI0YzllNTJkYTdjN2RmNGNjNWE3NzVjMzE4NGQwMTU5YzBhMzMxY2M3MTI0YzlmYTA1MTM3NjUxMTkwNiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.k_wcmva8gISHw1e_T8PmGmbxHPlfQma6A-jknXOVToY)
   > 
   > ### Proposal
   > #### 0 rows just opened
   > ![Screenshot 2025-02-19 
095500](https://private-user-images.githubusercontent.com/8044780/414639736-44c01a9a-b8ff-404a-a4ad-bb4069b560ac.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk5NTk3ODgsIm5iZiI6MTczOTk1OTQ4OCwicGF0aCI6Ii84MDQ0NzgwLzQxNDYzOTczNi00NGMwMWE5YS1iOGZmLTQwNGEtYTRhZC1iYjQwNjliNTYwYWMucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxOSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTlUMTAwNDQ4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9OWE5ODliZTUxNDM0YWIyYmI5Njk0Y2RmODY3OTJhZjZmNTg2ZjcwYjExZTIwMTJmYWIzNDgwMzhjMjgwMGNlMiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.xMdeNef73whx41uBD7A-V05ABfZ-M0Vxg9fHKCmwj3k)
   > 
   > #### 0 rows transformed to one row
   > ![Screenshot 2025-02-19 
095435](https://private-user-images.githubusercontent.com/8044780/414639681-ec50f962-d52b-4e89-ab7f-88d66d11a5cb.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk5NTk3ODgsIm5iZiI6MTczOTk1OTQ4OCwicGF0aCI6Ii84MDQ0NzgwLzQxNDYzOTY4MS1lYzUwZjk2Mi1kNTJiLTRlODktYWI3Zi04OGQ2NmQxMWE1Y2IucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxOSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTlUMTAwNDQ4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YTAwZWY5NzI3NDM5YzJmOTg1YTU3YjUxZDQzOTYyNDJiOWY5Nzg2NGI4OGQ0MjZiODFhYmI1MjY0NWZkNmMxYyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.QQiiH4GIhaVRZ5JpdkHlIw8Rfg8Kpcnb0eUqw27gUok)
   
   Thanks Jozef for the review and the proposal. I agree with you ,with these 
changes user can distinguish between dummy row and actual row.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to