rhkp commented on PR #2790: URL: https://github.com/apache/incubator-kie-tools/pull/2790#issuecomment-2671983063
> > > @rhkp I meant to review this package: https://github.com/apache/incubator-kie-tools/tree/main/packages/kogito-db-migrator-tool-image to check if the image tag name is correct. > > > > > > Hi @ricardozanini I understand what you are referring to. > > > > * Please note in the `kogito-db-migrator-tool-image` package currently we are making use of tag `main`. > > * Earlier we were using `latest` tag. > > * However based on [this review comment](https://github.com/apache/incubator-kie-tools/pull/2697#discussion_r1917118786) by @tiagobento we switched to using `main` there. > > * So the `kogito-db-migrator-tool-image` package is correct and we shouldn't change it. > > So every place required the tag `docker.io/apache/incubator-kie-kogito-db-migrator-tool` is correct? I'm not referring to the tag version, but the whole naming. Hi @ricardozanini I totally agree we need to change the image names in `sonataflow-operator` package from `quay.io/rhkp/incubator-kie-kogito-service-db-migration-postgresql:latest` to `docker.io/apache/incubator-kie-kogito-db-migrator-tool:main`. But please refer to my earlier [comment to @jakubschwan ](https://github.com/apache/incubator-kie-tools/pull/2790/files#r1924217939) and [to you too](https://github.com/apache/incubator-kie-tools/pull/2790/files#r1962263527) that we do not have the `docker.io/apache` image yet available on hub.docker as shown in [screenshot](https://github.com/apache/incubator-kie-tools/pull/2790#issuecomment-2669579956) shared yesterday. So we cannot update this image right now in this package. If we change the name at this moment to non-existent image, the operator will not work with DB migration job as the desired image `docker.io/apache/incubator-kie-kogito-db-migrator-tool:main` does not exist. My recommendation is to keep the current name **only for now** so the testing can proceed. And as soon as the real `docker.io/apache` image for db migration is **available**, we will update this one. Please let me know if we are on same understanding or still we have some difference in understanding? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
