yesamer commented on code in PR #6262:
URL:
https://github.com/apache/incubator-kie-drools/pull/6262#discussion_r1967515228
##########
kie-dmn/kie-dmn-validation/src/main/resources/org/kie/dmn/validation/DMNv1_2/dmn-validation-rules-dmndi.drl:
##########
@@ -90,6 +90,7 @@ when
$shape : DMNShape(dmnElementRef.prefix == XMLConstants.DEFAULT_NS_PREFIX)
not DRGElement(id == $shape.dmnElementRef.localPart)
not TextAnnotation(id == $shape.dmnElementRef.localPart)
+ not Group(id == $shape.dmnElementRef.localPart)
Review Comment:
@bncriju @gitgabrio @baldimir
There's an inconsistency here. We're adding a check about a Group element
that was introduced in DMN 1.3 in a validation rule in 1.2 directory. Of
course, this is because the current 1.2 validation rule set is currently used
to validate 1.5 DMN Models. As we agreed we'll tackle this problem in a future
task, but please just add here a comment that explains why we're checking a 1.3
Element in a 1.2 ruleset.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
