tiagobento opened a new pull request, #2940: URL: https://github.com/apache/incubator-kie-tools/pull/2940
During @jomarko's work on - https://github.com/apache/incubator-kie-tools/pull/2918 [I mentioned](https://github.com/apache/incubator-kie-tools/pull/2918#issuecomment-2675804896) that this work was a great opportunity for using [Shared values](https://github.com/apache/incubator-kie-tools/pull/691). However, a Shared value owned by an Envelope was currently not being exposed to it via EnvelopeClient, and therefore couldn't be used by the components inside an Envelope. Since for @jomarko's work, the state of which Boxed Expression is currently selected is _owned_ by the DMN Editor, it only made sense for the `dmn-editor-envelope` to own this Shared value. Investigating with him, we weren't able to find a way to consume it, then after insisting, I noticed that [EnvelopeServer](https://github.com/apache/incubator-kie-tools/blob/main/packages/envelope-bus/src/channel/EnvelopeServer.ts) was exposing its Shared values via the `shared` getter, but [EnvelopeClient](https://github.com/apache/incubator-kie-tools/blob/main/packages/envelope-bus/src/envelope/EnvelopeClient.ts) wasn't. This PR changes that. More than making EnvelopeClient expose its Shared values, I'm also adding a new `shared` property to `KogitoEditorEnvelopeContextType` so that all Editors running inside Envelopes can access Shared values they might come to declare. This PR turned out somewhat large, as lots of places needed the EnvelopeApi as a new type parameter, but real changes are in: - `KogitoEditorEnvelopeContext.ts` - Adding a new `shared` property - `EnvelopeClient.ts`; and - Adding a new `shared` getter - `examples/micro-frontends-multiplying-architecture-todo-list-view` - Adding a new Shared value (`todoList__itemsCount`) to the Envelope, and consuming it in the Channel. --- Also in this PR: - Fixing the top-level `on-changed-deps-only` script to always exclude changed packages, even if they're dependencies of other changed packages. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
