This is an automated email from the ASF dual-hosted git repository.
tiagobento pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-kie-tools.git
The following commit(s) were added to refs/heads/main by this push:
new e2a3ad58d5e NO-ISSUE: Rename DMN Runner 'Execution' to 'Evaluation'
(#2971)
e2a3ad58d5e is described below
commit e2a3ad58d5ec786d0eeb4ecc7ea71cb5d7d0e590
Author: Jozef Marko <[email protected]>
AuthorDate: Fri Mar 7 22:49:28 2025 +0100
NO-ISSUE: Rename DMN Runner 'Execution' to 'Evaluation' (#2971)
Co-authored-by: Tiago Bento <[email protected]>
---
packages/dmn-editor/src/DmnEditor.tsx | 2 +-
packages/form-dmn/src/FormDmnOutputs.tsx | 18 +++++++++---------
packages/form-dmn/tests/FormDmnOutputs.test.tsx | 2 +-
packages/i18n-common-dictionary/src/CommonI18n.ts | 2 +-
packages/i18n-common-dictionary/src/locales/de.ts | 2 +-
packages/i18n-common-dictionary/src/locales/en.ts | 2 +-
.../src/dmnRunner/DmnRunnerContextProvider.tsx | 6 +++---
.../src/dmnRunner/DmnRunnerDrawerPanelContent.tsx | 8 ++++----
.../src/editor/EditorPageDockContextProvider.tsx | 8 ++++----
.../NotificationsPanelTabContent.tsx | 4 ++--
packages/online-editor/src/i18n/locales/de.ts | 2 +-
packages/online-editor/src/i18n/locales/en.ts | 2 +-
.../src/editor/EditorPageDockDrawer.tsx | 6 +++---
.../NotificationsPanelTabContent.tsx | 4 ++--
14 files changed, 34 insertions(+), 34 deletions(-)
diff --git a/packages/dmn-editor/src/DmnEditor.tsx
b/packages/dmn-editor/src/DmnEditor.tsx
index acfd8e52cf1..8ed52f6298f 100644
--- a/packages/dmn-editor/src/DmnEditor.tsx
+++ b/packages/dmn-editor/src/DmnEditor.tsx
@@ -143,7 +143,7 @@ export type DmnEditorProps = {
*/
externalModelsByNamespace?: ExternalModelsIndex;
/**
- * To show information about execution results directly on the DMN diagram
and/or Boxed Expression Editor, use this prop.
+ * To show information about evaluation results directly on the DMN diagram
and/or Boxed Expression Editor, use this prop.
*/
evaluationResultsByNodeId?: EvaluationResultsByNodeId;
/**
diff --git a/packages/form-dmn/src/FormDmnOutputs.tsx
b/packages/form-dmn/src/FormDmnOutputs.tsx
index c3d99a93dea..7ee00287251 100644
--- a/packages/form-dmn/src/FormDmnOutputs.tsx
+++ b/packages/form-dmn/src/FormDmnOutputs.tsx
@@ -64,11 +64,11 @@ export interface FormDmnOutputsProps {
differences?: Array<DeepPartial<DecisionResult>>;
locale?: string;
notificationsPanel: boolean;
- openExecutionTab?: () => void;
+ openEvaluationTab?: () => void;
openBoxedExpressionEditor?: (nodeId: string) => void;
}
-export function FormDmnOutputs({ openExecutionTab, openBoxedExpressionEditor,
...props }: FormDmnOutputsProps) {
+export function FormDmnOutputs({ openEvaluationTab, openBoxedExpressionEditor,
...props }: FormDmnOutputsProps) {
const [formResultStatus, setFormResultStatus] =
useState<FormDmnOutputsStatus>(FormDmnOutputsStatus.EMPTY);
const [formResultError, setFormResultError] = useState<boolean>(false);
const i18n = useMemo(() => {
@@ -96,11 +96,11 @@ export function FormDmnOutputs({ openExecutionTab,
openBoxedExpressionEditor, ..
updatedResult?.classList.remove("kogito--editor__dmn-form-result__leaf-updated");
}, []);
- const onOpenExecutionTab = useCallback(() => {
+ const onOpenEvaluationTab = useCallback(() => {
if (props.notificationsPanel) {
- openExecutionTab?.();
+ openEvaluationTab?.();
}
- }, [props.notificationsPanel, openExecutionTab]);
+ }, [props.notificationsPanel, openEvaluationTab]);
const resultStatus = useCallback(
(evaluationStatus: DmnEvaluationStatus) => {
@@ -111,7 +111,7 @@ export function FormDmnOutputs({ openExecutionTab,
openBoxedExpressionEditor, ..
<div className={"kie-tools__dmn-form-result__evaluation"}>
<CheckCircleIcon />
{props.notificationsPanel ? (
- <a onClick={onOpenExecutionTab}
className={"kogito--editor__dmn-form-result__evaluation-link"}>
+ <a onClick={onOpenEvaluationTab}
className={"kogito--editor__dmn-form-result__evaluation-link"}>
{i18n.result.evaluation.succeeded}
</a>
) : (
@@ -128,7 +128,7 @@ export function FormDmnOutputs({ openExecutionTab,
openBoxedExpressionEditor, ..
<div className={"kie-tools__dmn-form-result__evaluation"}>
<Icon>↷</Icon>
{props.notificationsPanel ? (
- <a onClick={onOpenExecutionTab}
className={"kogito--editor__dmn-form-result__evaluation-link"}>
+ <a onClick={onOpenEvaluationTab}
className={"kogito--editor__dmn-form-result__evaluation-link"}>
{i18n.result.evaluation.skipped}
</a>
) : (
@@ -143,7 +143,7 @@ export function FormDmnOutputs({ openExecutionTab,
openBoxedExpressionEditor, ..
<div className={"kie-tools__dmn-form-result__evaluation"}>
<ExclamationCircleIcon />
{props.notificationsPanel ? (
- <a onClick={onOpenExecutionTab}
className={"kogito--editor__dmn-form-result__evaluation-link"}>
+ <a onClick={onOpenEvaluationTab}
className={"kogito--editor__dmn-form-result__evaluation-link"}>
{i18n.result.evaluation.failed}
</a>
) : (
@@ -158,7 +158,7 @@ export function FormDmnOutputs({ openExecutionTab,
openBoxedExpressionEditor, ..
i18n.result.evaluation.failed,
i18n.result.evaluation.skipped,
i18n.result.evaluation.succeeded,
- onOpenExecutionTab,
+ onOpenEvaluationTab,
props.notificationsPanel,
]
);
diff --git a/packages/form-dmn/tests/FormDmnOutputs.test.tsx
b/packages/form-dmn/tests/FormDmnOutputs.test.tsx
index 81e3adc5b77..885a8bb5ad7 100644
--- a/packages/form-dmn/tests/FormDmnOutputs.test.tsx
+++ b/packages/form-dmn/tests/FormDmnOutputs.test.tsx
@@ -27,7 +27,7 @@ const props: FormDmnOutputsProps = {
differences: [{}],
locale: "en",
notificationsPanel: true,
- openExecutionTab: () => {},
+ openEvaluationTab: () => {},
};
describe("FormDmnOutputs tests", () => {
diff --git a/packages/i18n-common-dictionary/src/CommonI18n.ts
b/packages/i18n-common-dictionary/src/CommonI18n.ts
index 889025bc3c6..a36e3712041 100644
--- a/packages/i18n-common-dictionary/src/CommonI18n.ts
+++ b/packages/i18n-common-dictionary/src/CommonI18n.ts
@@ -40,7 +40,7 @@ export type CommonDictionary = {
download: string;
edit: string;
edited: string;
- execution: string;
+ evaluation: string;
exit: string;
file: string;
files: string;
diff --git a/packages/i18n-common-dictionary/src/locales/de.ts
b/packages/i18n-common-dictionary/src/locales/de.ts
index 6c102f4cf4b..03d446ad7cb 100644
--- a/packages/i18n-common-dictionary/src/locales/de.ts
+++ b/packages/i18n-common-dictionary/src/locales/de.ts
@@ -42,7 +42,7 @@ export const de: CommonI18n = {
download: "Download",
edit: "Bearbeiten",
edited: "Editiert",
- execution: "Ausführung",
+ evaluation: "Auswertung",
exit: "Beenden",
file: "Datei",
files: "Dateien",
diff --git a/packages/i18n-common-dictionary/src/locales/en.ts
b/packages/i18n-common-dictionary/src/locales/en.ts
index ba234e64fc4..3235db61cf4 100644
--- a/packages/i18n-common-dictionary/src/locales/en.ts
+++ b/packages/i18n-common-dictionary/src/locales/en.ts
@@ -42,7 +42,7 @@ export const en: CommonI18n = {
download: "Download",
edit: "Edit",
edited: "Edited",
- execution: "Execution",
+ evaluation: "Evaluation",
exit: "Exit",
file: "File",
files: "Files",
diff --git a/packages/online-editor/src/dmnRunner/DmnRunnerContextProvider.tsx
b/packages/online-editor/src/dmnRunner/DmnRunnerContextProvider.tsx
index fdda208087c..e8fa3fe6743 100644
--- a/packages/online-editor/src/dmnRunner/DmnRunnerContextProvider.tsx
+++ b/packages/online-editor/src/dmnRunner/DmnRunnerContextProvider.tsx
@@ -432,7 +432,7 @@ export function DmnRunnerContextProvider(props:
PropsWithChildren<Props>) {
}, [dmnRunnerMode, isExpanded, onTogglePanel, panel]);
// END
- // Set execution tab on Problems panel;
+ // Set evaluation tab on Problems panel;
useEffect(() => {
if (props.workspaceFile.extension !== "dmn" || extendedServices.status !==
ExtendedServicesStatus.RUNNING) {
return;
@@ -466,10 +466,10 @@ export function DmnRunnerContextProvider(props:
PropsWithChildren<Props>) {
}));
});
- setNotifications(i18n.terms.execution, "", notifications as any);
+ setNotifications(i18n.terms.evaluation, "", notifications as any);
}, [
setNotifications,
- i18n.terms.execution,
+ i18n.terms.evaluation,
results,
currentInputIndex,
props.workspaceFile.extension,
diff --git
a/packages/online-editor/src/dmnRunner/DmnRunnerDrawerPanelContent.tsx
b/packages/online-editor/src/dmnRunner/DmnRunnerDrawerPanelContent.tsx
index d1bdd69171d..ef085998303 100644
--- a/packages/online-editor/src/dmnRunner/DmnRunnerDrawerPanelContent.tsx
+++ b/packages/online-editor/src/dmnRunner/DmnRunnerDrawerPanelContent.tsx
@@ -106,10 +106,10 @@ export function DmnRunnerDrawerPanelContent() {
notificationsPanel?.setActiveTab(i18n.terms.validation);
}, [i18n.terms.validation, notificationsPanel, onOpenPanel]);
- const openExecutionTab = useCallback(() => {
+ const openEvaluationTab = useCallback(() => {
onOpenPanel(PanelId.NOTIFICATIONS_PANEL);
- notificationsPanel?.setActiveTab(i18n.terms.execution);
- }, [i18n.terms.execution, notificationsPanel, onOpenPanel]);
+ notificationsPanel?.setActiveTab(i18n.terms.evaluation);
+ }, [i18n.terms.evaluation, notificationsPanel, onOpenPanel]);
useEffect(() => {
setDrawerError(false);
@@ -329,7 +329,7 @@ export function DmnRunnerDrawerPanelContent() {
differences={resultsDifference[currentInputIndex]}
locale={locale}
notificationsPanel={true}
- openExecutionTab={openExecutionTab}
+ openEvaluationTab={openEvaluationTab}
openBoxedExpressionEditor={
!isLegacyDmnEditor
? (nodeId: string) => {
diff --git
a/packages/online-editor/src/editor/EditorPageDockContextProvider.tsx
b/packages/online-editor/src/editor/EditorPageDockContextProvider.tsx
index 6052da972f4..f01f80ab293 100644
--- a/packages/online-editor/src/editor/EditorPageDockContextProvider.tsx
+++ b/packages/online-editor/src/editor/EditorPageDockContextProvider.tsx
@@ -108,14 +108,14 @@ export function EditorPageDockContextProvider({
const notificationsPanelTabNames = useMemo(() => {
if (workspaceFile.extension.toLowerCase() === "dmn") {
- return [i18n.terms.validation, i18n.terms.execution];
+ return [i18n.terms.validation, i18n.terms.evaluation];
}
return [i18n.terms.validation];
- }, [workspaceFile.extension, i18n.terms.validation, i18n.terms.execution]);
+ }, [workspaceFile.extension, i18n.terms.validation, i18n.terms.evaluation]);
useEffect(() => {
- if (!notificationsPanelTabNames.includes(i18n.terms.execution)) {
- notificationsToggle?.deleteNotificationsFromTab(i18n.terms.execution);
+ if (!notificationsPanelTabNames.includes(i18n.terms.evaluation)) {
+ notificationsToggle?.deleteNotificationsFromTab(i18n.terms.evaluation);
}
if (notificationsPanel && notificationsToggle) {
const notifications = notificationsToggle.getNotifications();
diff --git
a/packages/online-editor/src/editor/NotificationsPanel/NotificationsPanelTabContent.tsx
b/packages/online-editor/src/editor/NotificationsPanel/NotificationsPanelTabContent.tsx
index 3b3c567b62b..b9ce74f38cc 100644
---
a/packages/online-editor/src/editor/NotificationsPanel/NotificationsPanelTabContent.tsx
+++
b/packages/online-editor/src/editor/NotificationsPanel/NotificationsPanelTabContent.tsx
@@ -126,7 +126,7 @@ export const NotificationPanelTabContent =
React.forwardRef<NotificationsChannel
</NotificationDrawerList>
) : (
<NotificationTabDrawerGroup
- key={`execution-notification-group-${groupIndex}`}
+ key={`evaluation-notification-group-${groupIndex}`}
path={path}
notifications={notifications}
allExpanded={expandAll}
@@ -178,7 +178,7 @@ export function NotificationTabDrawerGroup({
onExpand={onExpand}
>
{notifications.map((notification, index) => (
- <NotificationDrawerList
key={`execution-notification-item-${path}-${index}`} isHidden={!isExpanded}>
+ <NotificationDrawerList
key={`evaluation-notification-item-${path}-${index}`} isHidden={!isExpanded}>
<NotificationDrawerListItem isRead={true}
variant={variant(notification.severity)}>
<NotificationDrawerListItemHeader title={notification.message}
variant={variant(notification.severity)} />
</NotificationDrawerListItem>
diff --git a/packages/online-editor/src/i18n/locales/de.ts
b/packages/online-editor/src/i18n/locales/de.ts
index 9459a886b98..6f0baf32574 100644
--- a/packages/online-editor/src/i18n/locales/de.ts
+++ b/packages/online-editor/src/i18n/locales/de.ts
@@ -455,7 +455,7 @@ export const de: OnlineI18n = {
notificationPanelExplanation: [
`Das Problem-Panel`,
wrapped("icon"),
- `, in der unteren rechten Ecke des Editors, zeigt
Live-Ausführungsmeldungen an, um Sie bei der Modellierung Ihrer Entscheidungen
zu unterstützen.`,
+ `, in der unteren rechten Ecke des Editors, zeigt
Live-Auswertungsmeldungen an, um Sie bei der Modellierung Ihrer Entscheidungen
zu unterstützen.`,
],
},
wizard: {
diff --git a/packages/online-editor/src/i18n/locales/en.ts
b/packages/online-editor/src/i18n/locales/en.ts
index a616e593f67..d738fc479b3 100644
--- a/packages/online-editor/src/i18n/locales/en.ts
+++ b/packages/online-editor/src/i18n/locales/en.ts
@@ -443,7 +443,7 @@ export const en: OnlineI18n = {
notificationPanelExplanation: [
`The Problems panel `,
wrapped("icon"),
- `, at the bottom-right corner of the Editor, displays live Execution
messages to assist modeling your decisions.`,
+ `, at the bottom-right corner of the Editor, displays live
Evaluation messages to assist modeling your Decisions.`,
],
},
wizard: {
diff --git
a/packages/serverless-logic-web-tools/src/editor/EditorPageDockDrawer.tsx
b/packages/serverless-logic-web-tools/src/editor/EditorPageDockDrawer.tsx
index 9923154252b..24207a25764 100644
--- a/packages/serverless-logic-web-tools/src/editor/EditorPageDockDrawer.tsx
+++ b/packages/serverless-logic-web-tools/src/editor/EditorPageDockDrawer.tsx
@@ -67,8 +67,8 @@ export const EditorPageDockDrawer = React.forwardRef<
const notificationsPanelTabNames = useMemo(() => [i18n.terms.validation],
[i18n.terms.validation]);
useEffect(() => {
- if (!notificationsPanelTabNames.includes(i18n.terms.execution)) {
- notificationsToggle?.deleteNotificationsFromTab(i18n.terms.execution);
+ if (!notificationsPanelTabNames.includes(i18n.terms.evaluation)) {
+ notificationsToggle?.deleteNotificationsFromTab(i18n.terms.evaluation);
}
if (notificationsPanel && notificationsToggle) {
const notifications = notificationsToggle.getNotifications();
@@ -76,7 +76,7 @@ export const EditorPageDockDrawer = React.forwardRef<
notificationsPanel.getTab(tabName)?.kogitoNotifications_setNotifications(value.path,
value.notifications);
});
}
- }, [i18n.terms.execution, notificationsPanel, notificationsPanelTabNames,
notificationsToggle]);
+ }, [i18n.terms.evaluation, notificationsPanel, notificationsPanelTabNames,
notificationsToggle]);
const onToggle = useCallback((panel: PanelId) => {
setPanel((currentPanel) => {
diff --git
a/packages/serverless-logic-web-tools/src/editor/NotificationsPanel/NotificationsPanelTabContent.tsx
b/packages/serverless-logic-web-tools/src/editor/NotificationsPanel/NotificationsPanelTabContent.tsx
index e4900cc6508..f73ad162ec9 100644
---
a/packages/serverless-logic-web-tools/src/editor/NotificationsPanel/NotificationsPanelTabContent.tsx
+++
b/packages/serverless-logic-web-tools/src/editor/NotificationsPanel/NotificationsPanelTabContent.tsx
@@ -128,7 +128,7 @@ export const NotificationPanelTabContent =
React.forwardRef<NotificationsChannel
</NotificationDrawerList>
) : (
<NotificationTabDrawerGroup
- key={`execution-notification-group-${groupIndex}`}
+ key={`evaluation-notification-group-${groupIndex}`}
path={path}
notifications={notifications}
allExpanded={props.expandAll}
@@ -175,7 +175,7 @@ export function NotificationTabDrawerGroup(props:
NotificationDrawerGroupProps)
onExpand={onExpand}
>
{props.notifications.map((notification, index) => (
- <NotificationDrawerList
key={`execution-notification-item-${props.path}-${index}`}
isHidden={!isExpanded}>
+ <NotificationDrawerList
key={`evaluation-notification-item-${props.path}-${index}`}
isHidden={!isExpanded}>
<NotificationDrawerListItem isRead={true}
variant={variant(notification.severity)}>
<NotificationDrawerListItemHeader title={notification.message}
variant={variant(notification.severity)} />
</NotificationDrawerListItem>
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
