jomarko commented on code in PR #2986:
URL:
https://github.com/apache/incubator-kie-tools/pull/2986#discussion_r1990922876
##########
packages/dmn-editor/src/DmnEditor.css:
##########
@@ -20,6 +20,7 @@
/* (begin) global */
.kie-dmn-editor--root {
height: 100%;
+ scrollbar-color: var(--vscode-scrollbarSlider-background) #f1f1f1;
Review Comment:
Don't we want to use `var` also instead of the constant `#f1f1f1` ?
Patternfly seems to have a lot of 'grey' colors already defined, like
`--pf-global--BorderColor--200`. Not sure, just asking. My idea was to minimize
the amount of 'grey' colors we use in tooling. However, I understand scrollbars
are more like host machine component that part of tooling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
