ricardozanini commented on code in PR #3028:
URL: 
https://github.com/apache/incubator-kie-tools/pull/3028#discussion_r2012124184


##########
packages/kn-plugin-workflow/pkg/command/quarkus/quarkus_project.go:
##########
@@ -205,12 +205,15 @@ func manipulatePomToKogito(filename string, cfg 
CreateQuarkusProjectConfig) erro
 }
 
 func manipulateDockerIgnore(filename string) error {
-       line := "\n!target/classes/workflow.sw.json"
+       pattern := "\n!target/classes/*.sw.%s"
+       extensions := []string{"json", "yaml"}

Review Comment:
   ```suggestion
        extensions := []string{"json", "yaml", "yml"}
   ```



##########
packages/kn-plugin-workflow/pkg/command/quarkus/quarkus_project.go:
##########
@@ -220,7 +223,8 @@ func manipulateDockerIgnore(filename string) error {
 }
 
 func manipulateDockerfile(filename string) error {
-       text := "COPY target/classes/workflow.sw.json 
/deployments/app/workflow.sw.json"
+       extensions := []string {"json", "yaml"}

Review Comment:
   ```suggestion
        extensions := []string {"json", "yaml", "yml"}
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to