This is an automated email from the ASF dual-hosted git repository.
tiagobento pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-kie-tools.git
The following commit(s) were added to refs/heads/main by this push:
new e79b136cf71 kie-issues#1512: DMN Editor: Context result row change
causes expression data type to be reverted (#3040)
e79b136cf71 is described below
commit e79b136cf71c4d0f8e49f80994fa329f57612f25
Author: Kusuma04-dev <[email protected]>
AuthorDate: Fri Apr 4 22:16:11 2025 +0530
kie-issues#1512: DMN Editor: Context result row change causes expression
data type to be reverted (#3040)
Co-authored-by: chinnamatli kusumalatha
<[email protected]>
Co-authored-by: Jozef Marko <[email protected]>
---
.../ContextResultExpressionCell.tsx | 3 ---
.../boxedExpressions/context/populate.spec.ts | 26 ++++++++++++++++++++++
2 files changed, 26 insertions(+), 3 deletions(-)
diff --git
a/packages/boxed-expression-component/src/expressions/ContextExpression/ContextResultExpressionCell.tsx
b/packages/boxed-expression-component/src/expressions/ContextExpression/ContextResultExpressionCell.tsx
index ef0334356dd..f786cafe97b 100644
---
a/packages/boxed-expression-component/src/expressions/ContextExpression/ContextResultExpressionCell.tsx
+++
b/packages/boxed-expression-component/src/expressions/ContextExpression/ContextResultExpressionCell.tsx
@@ -61,13 +61,10 @@ export function ContextResultExpressionCell(props: {
} else {
newContextEntries.splice(resultIndex, 1);
}
-
// Do not inline this variable for type safety. See
https://github.com/microsoft/TypeScript/issues/241
const ret: Normalized<BoxedContext> = {
...prev,
contextEntry: newContextEntries,
- "@_label": newExpression?.["@_label"] ?? prev["@_label"],
- "@_typeRef": newExpression?.["@_typeRef"] ?? prev["@_typeRef"],
};
return ret;
diff --git
a/packages/boxed-expression-component/tests-e2e/boxedExpressions/context/populate.spec.ts
b/packages/boxed-expression-component/tests-e2e/boxedExpressions/context/populate.spec.ts
index 42c7ce77b89..d343758dc39 100644
---
a/packages/boxed-expression-component/tests-e2e/boxedExpressions/context/populate.spec.ts
+++
b/packages/boxed-expression-component/tests-e2e/boxedExpressions/context/populate.spec.ts
@@ -98,4 +98,30 @@ test.describe("Populate Boxed Context", () => {
await
expect(bee.getContainer()).toHaveScreenshot("boxed-context-pre-bureau-risk-category.png");
});
+
+ test("should not revert context header when '<result>' cell is edited",
async ({ stories, bee }) => {
+ test.info().annotations.push({
+ type: TestAnnotations.REGRESSION,
+ description:
"https://github.com/apache/incubator-kie-issues/issues/1512";,
+ });
+
+ await stories.openBoxedContext();
+
+ // edit '<result>' cell for the fist time
+ await
bee.expression.asContext().result.selectExpressionMenu.selectLiteral();
+ await bee.expression.asContext().result.expression.asLiteral().fill("1");
+
+ // change the context header
+ await bee.expression.asContext().expressionHeaderCell.open();
+ await bee.expression.asContext().expressionHeaderCell.setName({ name: "New
Expression Name", close: false });
+ await bee.expression.asContext().expressionHeaderCell.setDataType({
dataType: "number", close: true });
+
+ // edit '<result>' cell for the second time
+ await bee.expression.asContext().result.expression.asLiteral().fill("2");
+
+ // check the context header is not changed since last edit
+ expect(await
bee.expression.asContext().expressionHeaderCell.getName()).toBe("New Expression
Name");
+ expect(await
bee.expression.asContext().expressionHeaderCell.getDataType()).toBe("(number)");
+ await
expect(bee.expression.asContext().result.expression.asLiteral().cell.content).toContainText("2");
+ });
});
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
