porcelli commented on code in PR #3873:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/3873#discussion_r2020035492
##########
quarkus/addons/fabric8-kubernetes-service-catalog/runtime/src/test/java/org/kie/kogito/addons/quarkus/fabric8/k8s/service/catalog/OpenShiftServiceDiscoveryTest.java:
##########
@@ -18,133 +18,134 @@
*/
package org.kie.kogito.addons.quarkus.fabric8.k8s.service.catalog;
-import java.net.URI;
-import java.util.Optional;
-
-import org.junit.jupiter.api.Test;
-
-import io.fabric8.kubernetes.api.model.Pod;
-import io.fabric8.kubernetes.api.model.ReplicationController;
-import io.fabric8.kubernetes.api.model.Service;
-import io.fabric8.openshift.api.model.DeploymentConfig;
-import io.fabric8.openshift.api.model.Route;
-import io.fabric8.openshift.client.server.mock.OpenShiftServer;
-import io.quarkus.test.junit.QuarkusTest;
-import io.quarkus.test.kubernetes.client.OpenShiftTestServer;
-import io.quarkus.test.kubernetes.client.WithOpenShiftTestServer;
-
-import jakarta.inject.Inject;
-
-import static org.junit.jupiter.api.Assertions.assertEquals;
-
-@QuarkusTest
-@WithOpenShiftTestServer
+//
+//import java.net.URI;
+//import java.util.Optional;
+//
+//import org.junit.jupiter.api.Test;
+//
+//import io.fabric8.kubernetes.api.model.Pod;
+//import io.fabric8.kubernetes.api.model.ReplicationController;
+//import io.fabric8.kubernetes.api.model.Service;
+//import io.fabric8.openshift.api.model.DeploymentConfig;
+//import io.fabric8.openshift.api.model.Route;
+//import io.fabric8.openshift.client.server.mock.OpenShiftServer;
+//import io.quarkus.test.junit.QuarkusTest;
+//import io.quarkus.test.kubernetes.client.OpenShiftTestServer;
+//import io.quarkus.test.kubernetes.client.WithOpenShiftTestServer;
Review Comment:
@ricardozanini @fjtirado @wmedvede openshift model has been removed. so this
test requires to be revisited.
##########
quarkus/addons/fabric8-kubernetes-service-catalog/test-utils/pom.xml:
##########
@@ -63,7 +63,7 @@
</dependency>
<dependency>
<groupId>io.quarkus</groupId>
- <artifactId>quarkus-test-openshift-client</artifactId>
+ <artifactId>quarkus-openshift-client</artifactId>
Review Comment:
@ricardozanini @fjtirado @wmedvede probably test-kubernetes should be used
here.. I don't know
##########
quarkus/addons/fabric8-kubernetes-service-catalog/runtime/pom.xml:
##########
@@ -72,7 +76,7 @@
</dependency>
<dependency>
<groupId>io.quarkus</groupId>
- <artifactId>quarkus-test-openshift-client</artifactId>
+ <artifactId>quarkus-test-kubernetes-client</artifactId>
Review Comment:
@ricardozanini @fjtirado @wmedvede openshift model has been removed
##########
quarkus/extensions/kogito-quarkus-serverless-workflow-extension/kogito-quarkus-serverless-workflow-deployment/src/main/java/org/kie/kogito/serverless/workflow/parser/schema/JsonSchemaImpl.java:
##########
@@ -41,6 +40,8 @@
@JsonInclude(JsonInclude.Include.NON_NULL)
public class JsonSchemaImpl extends SchemaImpl {
+ public static final String REF_PREFIX_SCHEMA = "#/components/schemas/";
Review Comment:
@ricardozanini @fjtirado @wmedvede this has changed, this REF_PREFIX_SCHEMA
constant is not available anymore in OpenApiConstants
##########
quarkus/extensions/kogito-quarkus-serverless-workflow-extension/kogito-quarkus-serverless-workflow-deployment/src/main/java/org/kie/kogito/quarkus/serverless/workflow/deployment/livereload/LiveReloadProcessor.java:
##########
@@ -189,7 +189,7 @@ private Collection<GeneratedFile>
generateSources(LiveReloadableCodeGenProvider
Path classPath =
outDir.getParent().getParent().resolve("classes");
Path serviceLoaderPath =
classPath.resolve("META-INF/services");
if (Files.isDirectory(classPath) &&
Files.isDirectory(serviceLoaderPath)) {
- classLoader.addElement(new
PathTreeClassPathElement(PathTree.ofDirectoryOrFile(classPath), true));
+ classLoader.addNormalPriorityElement(new
PathTreeClassPathElement(PathTree.ofDirectoryOrFile(classPath), true));
Review Comment:
@ricardozanini @fjtirado @wmedvede this has changed, please double check
##########
quarkus/extensions/kogito-quarkus-serverless-workflow-extension/kogito-quarkus-serverless-workflow-deployment/src/main/java/org/kie/kogito/quarkus/serverless/workflow/deployment/livereload/LiveReloadProcessor.java:
##########
@@ -138,7 +138,7 @@ private CodeGenerationResult
generateCode(LiveReloadableCodeGenProvider codeGenP
Collection<GeneratedFile> generatedFiles = new
ArrayList<>(generateSources(codeGenProvider));
Collection<GeneratedBeanBuildItem> generatedBeans =
compileGeneratedSources(generatedFiles);
if (!generatedBeans.isEmpty()) {
- classLoader.addElement(new MemoryClassPathElement(
+ classLoader.addNormalPriorityElement(new
MemoryClassPathElement(
Review Comment:
@ricardozanini @fjtirado @wmedvede this has changed, please double check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
