jomarko commented on code in PR #6303:
URL:
https://github.com/apache/incubator-kie-drools/pull/6303#discussion_r2039081583
##########
kie-dmn/kie-dmn-feel/src/test/java/org/kie/dmn/feel/runtime/functions/DateTimeFunctionTest.java:
##########
@@ -124,4 +127,55 @@ void invokeParamTemporalOffsetTime() {
OffsetTime.of(10, 6, 20, 0, ZoneOffset.UTC)),
ZonedDateTime.of(2017, 6, 12, 10, 6, 20, 0, ZoneOffset.UTC));
}
+
+ @Test
+ void invokeParamStringDateTimeZone() {
+
FunctionTestUtil.assertResult(dateTimeFunction.invoke(LocalDate.of(2024, 12,
24),
+ LocalTime.of(23, 59, 0),
+ "America/Costa_Rica"),
+ ZonedDateTime.of(2024, 12, 24, 23, 59, 0, 0,
ZoneId.of("America/Costa_Rica")));
+ FEELFnResult<TemporalAccessor> expectedResult =
dateTimeFunction.invoke(LocalDate.of(2024, 12, 24), LocalTime.of(23, 59, 0),
"America/Costa_Rica");
+ FEELFnResult<TemporalAccessor> retrievedResult =
dateTimeFunction.invoke("2024-12-24T23:59:00@America/Costa_Rica");
+
assertThat(expectedResult.getOrElse(null)).isEqualTo(retrievedResult.getOrElse(null));
Review Comment:
hmm, maybe I am missing something, here theoretically the test will pass,
even if both `expectedResult` and `retrievedResult` are `null`. Am I wrong? If
tno, I think we should add assertion `expectedResult` and `retrievedResult` are
both not `null`.
##########
kie-dmn/kie-dmn-feel/src/test/java/org/kie/dmn/feel/runtime/functions/DateTimeFunctionTest.java:
##########
@@ -124,4 +127,55 @@ void invokeParamTemporalOffsetTime() {
OffsetTime.of(10, 6, 20, 0, ZoneOffset.UTC)),
ZonedDateTime.of(2017, 6, 12, 10, 6, 20, 0, ZoneOffset.UTC));
}
+
+ @Test
+ void invokeParamStringDateTimeZone() {
+
FunctionTestUtil.assertResult(dateTimeFunction.invoke(LocalDate.of(2024, 12,
24),
+ LocalTime.of(23, 59, 0),
+ "America/Costa_Rica"),
+ ZonedDateTime.of(2024, 12, 24, 23, 59, 0, 0,
ZoneId.of("America/Costa_Rica")));
+ FEELFnResult<TemporalAccessor> expectedResult =
dateTimeFunction.invoke(LocalDate.of(2024, 12, 24), LocalTime.of(23, 59, 0),
"America/Costa_Rica");
+ FEELFnResult<TemporalAccessor> retrievedResult =
dateTimeFunction.invoke("2024-12-24T23:59:00@America/Costa_Rica");
+
assertThat(expectedResult.getOrElse(null)).isEqualTo(retrievedResult.getOrElse(null));
+ }
+
+ @Test
+ void testParamStringDateTimeZone() {
+ FEELFnResult<TemporalAccessor> result =
dateTimeFunction.invoke(LocalDate.of(2024, 12, 24), LocalTime.of(23, 59, 0),
"Z");
+ ZonedDateTime actualDateTime = (ZonedDateTime) result.getOrElse(null);
+ ZonedDateTime expectedDateTime = ZonedDateTime.of(2024, 12, 24, 23,
59, 0, 0, ZoneOffset.UTC);
+ assertThat(expectedDateTime).isEqualTo(actualDateTime);
+ FEELFnResult<TemporalAccessor> retrievedResult =
dateTimeFunction.invoke("2024-12-24T23:59:00Z");
+ assertThat(actualDateTime).isEqualTo(retrievedResult.getOrElse(null));
Review Comment:
same comment as above, just different test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
