tiagobento commented on code in PR #6311: URL: https://github.com/apache/incubator-kie-drools/pull/6311#discussion_r2047246640
########## kie-dmn/kie-dmn-xsd-resources/Readme.md: ########## @@ -0,0 +1,35 @@ +<!-- + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + --> + +KIE :: Decision Model Notation :: XSD-Bundle +============================================ + +This modules is used to bundle all the DMN-related xsd in one single jar, fetching them from [official repository](https://www.omg.org/spec/DMN/). Review Comment: ```suggestion This module is used to bundle all the DMN-related XSD files in one single jar, fetching them from the [official repository](https://www.omg.org/spec/DMN/). ``` ########## kie-dmn/kie-dmn-xsd-resources/Readme.md: ########## @@ -0,0 +1,35 @@ +<!-- + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + --> + +KIE :: Decision Model Notation :: XSD-Bundle Review Comment: ```suggestion KIE :: Decision Model and Notation :: XSD-Bundle ``` ########## kie-dmn/kie-dmn-backend/pom.xml: ########## @@ -38,6 +38,16 @@ <java.module.name>org.kie.dmn.backend</java.module.name> </properties> + <dependencyManagement> + <dependencies> + <dependency> + <groupId>org.kie</groupId> + <artifactId>kie-dmn-xsd-resources</artifactId> + <version>${project.version}</version> + </dependency> + </dependencies> + </dependencyManagement> Review Comment: Shouldn't we be adding this new module to the BOM so that we don't need to declare it in multiple places? ########## kie-dmn/kie-dmn-xsd-resources/pom.xml: ########## @@ -0,0 +1,297 @@ +<!-- + + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + +--> +<project xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + <parent> + <groupId>org.kie</groupId> + <artifactId>kie-dmn</artifactId> + <version>999-SNAPSHOT</version> + </parent> + + <artifactId>kie-dmn-xsd-resources</artifactId> + <name>KIE :: Decision Model Notation :: XSD-Bundle</name> Review Comment: ```suggestion <name>KIE :: Decision Model and Notation :: XSD-Bundle</name> ``` ########## kie-dmn/kie-dmn-xsd-resources/pom.xml: ########## @@ -0,0 +1,297 @@ +<!-- + + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + +--> +<project xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + <parent> + <groupId>org.kie</groupId> + <artifactId>kie-dmn</artifactId> + <version>999-SNAPSHOT</version> + </parent> + + <artifactId>kie-dmn-xsd-resources</artifactId> + <name>KIE :: Decision Model Notation :: XSD-Bundle</name> + <description>Module meant to bundle all DMN-related xsd files</description> + + <properties> + <java.module.name>org.kie.dmn.xsd.resources</java.module.name> + <maven.compiler.source>17</maven.compiler.source> + <maven.compiler.target>17</maven.compiler.target> + <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> + <download-maven-plugin.version>2.0.0</download-maven-plugin.version> Review Comment: Maybe this should be managed in the build-parent POM? ########## kie-dmn/kie-dmn-xsd-resources/pom.xml: ########## @@ -0,0 +1,297 @@ +<!-- + + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + +--> +<project xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + <parent> + <groupId>org.kie</groupId> + <artifactId>kie-dmn</artifactId> + <version>999-SNAPSHOT</version> + </parent> + + <artifactId>kie-dmn-xsd-resources</artifactId> + <name>KIE :: Decision Model Notation :: XSD-Bundle</name> + <description>Module meant to bundle all DMN-related xsd files</description> + + <properties> + <java.module.name>org.kie.dmn.xsd.resources</java.module.name> + <maven.compiler.source>17</maven.compiler.source> + <maven.compiler.target>17</maven.compiler.target> + <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> + <download-maven-plugin.version>2.0.0</download-maven-plugin.version> + <output.spec.directory>${project.build.directory}/classes/org/omg/spec/DMN</output.spec.directory> + </properties> + + <build> + <pluginManagement> + <plugins> + <plugin> + <groupId>io.github.download-maven-plugin</groupId> + <artifactId>download-maven-plugin</artifactId> + <version>${download-maven-plugin.version}</version> + </plugin> + </plugins> + </pluginManagement> Review Comment: Same question here... shouldn't we be managing this in the build parent POM? ########## kie-dmn/kie-dmn-xsd-resources/pom.xml: ########## @@ -0,0 +1,297 @@ +<!-- + + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + +--> +<project xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + <parent> + <groupId>org.kie</groupId> + <artifactId>kie-dmn</artifactId> + <version>999-SNAPSHOT</version> + </parent> + + <artifactId>kie-dmn-xsd-resources</artifactId> + <name>KIE :: Decision Model Notation :: XSD-Bundle</name> + <description>Module meant to bundle all DMN-related xsd files</description> + + <properties> + <java.module.name>org.kie.dmn.xsd.resources</java.module.name> + <maven.compiler.source>17</maven.compiler.source> + <maven.compiler.target>17</maven.compiler.target> + <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> Review Comment: Do we need those repeated here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
