tkobayas commented on PR #6313: URL: https://github.com/apache/incubator-kie-drools/pull/6313#issuecomment-2814844433
@mariofusco This PR delays `scheduleExpiration` from "the time of insert" to "after the rule evaluation" Indeed, it failed with `OOPathCepTest.testEventExplicitExpirationWithOOPath` which does: - insert an event with 2 seconds expiration - advance time 3 seconds (so the events gets expired) - assert that fireAllRules doens't fire a rule https://github.com/apache/incubator-kie-drools/blob/main/drools-test-coverage/test-suite/src/test/java/org/drools/testcoverage/functional/oopath/OOPathCepTest.java#L786 If we want to keep this behavior (= an event can be expired before fireAllRules), we should not apply this PR. I wonder if removing the behavior makes any problem from functionaliy or memory perspective. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
