ChinchuAjith commented on code in PR #6299:
URL:
https://github.com/apache/incubator-kie-drools/pull/6299#discussion_r2066057301
##########
kie-dmn/kie-dmn-feel/src/main/java/org/kie/dmn/feel/runtime/functions/CeilingFunction.java:
##########
@@ -39,17 +42,15 @@ public FEELFnResult<BigDecimal> invoke(@ParameterName( "n"
) BigDecimal n) {
}
public FEELFnResult<BigDecimal> invoke(@ParameterName( "n" ) BigDecimal n,
@ParameterName( "scale" ) BigDecimal scale) {
- if ( n == null ) {
- return FEELFnResult.ofError(new
InvalidParametersEvent(Severity.ERROR, "n", "cannot be null"));
- }
- if ( scale == null ) {
- return FEELFnResult.ofError(new
InvalidParametersEvent(Severity.ERROR, "scale", "cannot be null"));
+ try {
+ int coercedN = coerceIntegerNumber(n).orElseThrow(() -> new
NoSuchElementException("n"));
Review Comment:
Reviewed the spec and found no reference to coercion for variable n, so I
removed it. The null check has been retained.
##########
kie-dmn/kie-dmn-feel/src/main/java/org/kie/dmn/feel/runtime/functions/DecimalFunction.java:
##########
@@ -34,18 +37,17 @@ private DecimalFunction() {
super( "decimal" );
}
- public FEELFnResult<BigDecimal> invoke(@ParameterName( "n" ) BigDecimal n,
@ParameterName( "scale" ) BigDecimal scale) {
- if ( n == null ) {
- return FEELFnResult.ofError(new
InvalidParametersEvent(Severity.ERROR, "n", "cannot be null"));
- }
- if ( scale == null ) {
- return FEELFnResult.ofError(new
InvalidParametersEvent(Severity.ERROR, "scale", "cannot be null"));
+ public FEELFnResult<BigDecimal> invoke(@ParameterName("n") BigDecimal n,
@ParameterName("scale") BigDecimal scale) {
+ try {
+ int coercedN = coerceIntegerNumber(n).orElseThrow(() -> new
NoSuchElementException("n"));
Review Comment:
Reviewed the spec and found no reference to coercion for variable n, so I
removed it. The null check has been retained.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
