fantonangeli commented on PR #3100: URL: https://github.com/apache/incubator-kie-tools/pull/3100#issuecomment-2850129017
> Asking @ljmotta's assessment here since he knows a great deal about `uniforms-patternfly`. > > From a first glance, I might be inclined to say `uniforms-patternfly` should rely on https://v5-archive.patternfly.org/components/code-editor instead of `@kie-tools/monaco-editor`. WDYT @fantonangeli? @tiagobento thanks a lot for this suggestion. I think Patterfly's code-editor can be easier to include and test on the jest side. In addition to that, not relying on `@kie-tools/monaco-editor` can possibly keep `uniforms-patternfly` easier to use on non KIE projects. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
