jomarko commented on code in PR #3128:
URL:
https://github.com/apache/incubator-kie-tools/pull/3128#discussion_r2086075106
##########
packages/dmn-editor-envelope/tests-e2e/__screenshots__/Google-Chrome/features/keyboard/deleted-decision-node-using-backspace.png:
##########
Review Comment:
Also here, same question, do we test node deletion or node name deletion?
##########
packages/dmn-editor-envelope/tests-e2e/__screenshots__/Google-Chrome/features/keyboard/selected-all-nodes.png:
##########
Review Comment:
the screenshot name seems to be different than the screenshot content, is it
expected?
- name says `all`
- while content has single node selected
##########
packages/dmn-editor-envelope/tests-e2e/__screenshots__/Google-Chrome/features/keyboard/show-properties-using-shoftcut.png:
##########
Review Comment:
I think I do not see properties in the screenshot content, could you please
clarify if the screenshot is correct?
##########
packages/dmn-editor-envelope/tests-e2e/__screenshots__/Google-Chrome/features/keyboard/zoomed-drd-using-shortcut.png:
##########
Review Comment:
comparing other screenshots, it sounds zoom level is same, could you please
clarify?
##########
packages/chrome-extension-pack-kogito-kie-editors/e2e-tests/tests/BpmnFullScreenTest.ts:
##########
@@ -32,7 +32,7 @@ beforeEach(async () => {
tools = await Tools.init(TEST_NAME);
});
-test(TEST_NAME, async () => {
+test.skip(TEST_NAME, async () => {
Review Comment:
If the `skip` is intentional, we should explain it as we do for `Copy/Paste
node using shotcuts`
##########
packages/dmn-editor-envelope/tests-e2e/__screenshots__/Google-Chrome/features/keyboard/unselected-all-nodes.png:
##########
Review Comment:
could you please clarify if the screenshot is correct?
##########
packages/dmn-editor-envelope/tests-e2e/__screenshots__/Google-Chrome/features/keyboard/deleted-decision-node-delete.png:
##########
Review Comment:
Do we test node deletion or node name deletion?
##########
packages/dmn-editor-envelope/tests-e2e/__screenshots__/Google-Chrome/features/keyboard/zoomed-out-drd-using-shortcut.png:
##########
Review Comment:
cold you please clarify if the screenshot is correct? it seems like 100%
zoom level
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
