aswathitv commented on code in PR #3046:
URL:
https://github.com/apache/incubator-kie-tools/pull/3046#discussion_r2088303578
##########
packages/dmn-editor/tests-e2e/drds/modelDecisionServicesInDrds.spec.ts:
##########
@@ -103,13 +145,29 @@ test.describe("Model Decision Services - DRD", () => {
// TODO, question, not understand
});
- test("892 collapse - remove its content", async ({ drds }) => {
- test.skip(true,
"https://github.com/apache/incubator-kie-issues/issues/892";);
+ test("892 collapse - remove its content", async ({ editor, palette, nodes,
diagram }) => {
test.info().annotations.push({
type: TestAnnotations.REGRESSION,
description: "https://github.com/apache/incubator-kie-issues/issues/892";,
});
- // TODO
+ await palette.dragNewNode({ type: NodeType.DECISION_SERVICE,
targetPosition: { x: 400, y: 200 } });
+ await expect(nodes.get({ name: DefaultNodeName.DECISION_SERVICE
})).toBeAttached();
+
+ await palette.dragNewNode({
+ type: NodeType.DECISION,
+ targetPosition: { x: 200, y: 200 },
+ thenRenameTo: "User Decision",
+ });
+ await expect(nodes.get({ name: "User Decision" })).toBeAttached();
+
+ await nodes.move({ name: "User Decision", targetPosition: { x: 500, y: 300
} });
+ await expect(nodes.get({ name: "User Decision" })).toBeAttached();
+
+ await nodes.select({ name: DefaultNodeName.DECISION_SERVICE, position:
NodePosition.TOP });
+ await editor.collapseDecisionService();
Review Comment:
Added selecting node step to selectAndCollapseDecisionService
##########
packages/dmn-editor/tests-e2e/drds/modelDecisionServicesInDrds.spec.ts:
##########
@@ -48,15 +49,56 @@ test.describe("Model Decision Services - DRD", () => {
// its content should be automatically layout-ed
});
- test("888 add to DRD, mix of collapsed and expanded", async ({ drds }) => {
- test.skip(true,
"https://github.com/apache/incubator-kie-issues/issues/888";);
+ test("888 add to DRD, mix of collapsed and expanded", async ({ drds,
palette, nodes, diagram, drgNodes }) => {
Review Comment:
Added all the changes as mentioned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
