ricardozanini commented on code in PR #3144:
URL:
https://github.com/apache/incubator-kie-tools/pull/3144#discussion_r2098168853
##########
packages/kn-plugin-workflow/pkg/command/quarkus/create.go:
##########
@@ -65,13 +78,36 @@ func NewCreateCommand() *cobra.Command {
cmd.Flags().StringP("extension", "e", "", "On Quarkus projects, setup
project custom Maven extensions, separated with a comma.")
cmd.Flags().StringP("quarkus-platform-group-id", "G",
quarkusDependencies.QuarkusPlatformGroupId, "On Quarkus projects, setup project
group id.")
cmd.Flags().StringP("quarkus-version", "V",
quarkusDependencies.QuarkusVersion, "On Quarkus projects, setup the project
version.")
+ cmd.Flags().StringP("profile", "p", "dev", "Specify a profile to use
for the new Quarkus project (default: dev)")
+ cmd.Flags().BoolP("with-persistence", "w", false, "Add persistence
support to the project (default: false)")
+
cmd.SetHelpFunc(common.DefaultTemplatedHelp)
return cmd
}
-func runCreate() error {
- cfg, err := runCreateCmdConfig()
+type MavenDependency struct {
+ GroupId string
+ ArtifactId string
+}
+
+var ExtensionPerProfile = map[string][]MavenDependency{
+ apiMetadata.GitOpsProfile.String(): {
+
MavenDependency{"org.kie","kie-addons-quarkus-persistence-jdbc"},
Review Comment:
We should start thinking about adding a configuration locally. The groupId
here might change downstream, for example.
##########
packages/kn-plugin-workflow/pkg/common/checks.go:
##########
@@ -197,3 +198,23 @@ func CheckProjectName(name string) (err error) {
}
return
}
+
+func IsValidProfile(profile string) error {
+ var allProfiles = []apiMetadata.ProfileType{
+ apiMetadata.DevProfile,
+ apiMetadata.ProdProfile,
Review Comment:
This one has been deprecated. Can you remove it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
