mariofusco commented on code in PR #6354:
URL:
https://github.com/apache/incubator-kie-drools/pull/6354#discussion_r2102192919
##########
drools-model/drools-model-codegen/src/main/java/org/drools/model/codegen/execmodel/generator/operatorspec/CustomOperatorWrapper.java:
##########
@@ -35,7 +35,8 @@ public CustomOperatorWrapper( Evaluator evaluator, String
name ) {
@Override
public boolean eval( Object o1, Object o2 ) {
- return evaluator.evaluate(null, null, dummyFactHandleOf(o2), null,
dummyFactHandleOf(o1));
+ // o1 and o2 are the left and right operands of the expression, so
this order. (See Evaluator.evaluate)
+ return evaluator.evaluate(null, null, dummyFactHandleOf(o1), null,
dummyFactHandleOf(o2));
Review Comment:
Yes it makes sense. Maybe just change the variable names from `o1` and `o2`
to `leftOperand` and `rightOperand`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
