Copilot commented on code in PR #6355: URL: https://github.com/apache/incubator-kie-drools/pull/6355#discussion_r2104259556
########## drools-util/src/main/java/org/drools/util/PathUtils.java: ########## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.drools.util; + +import java.nio.file.Path; +import java.nio.file.Paths; + +/** + * Class meant to provide utility methods specific to <code>Path</code> management + */ +public class PathUtils { + + private PathUtils() { + } + + public static Path getSecuredPath(Path basePath, String userPathStr) { + Path targetPath = basePath.resolve(userPathStr).normalize(); + + if (!targetPath.startsWith(basePath)) { + throw new SecurityException("Path traversal attempt detected: " + userPathStr); + } + + String securePath = trimTrailingSeparator(targetPath.toString().replace('\\', '/')); + return Paths.get(securePath); Review Comment: Avoid string‐based manipulation of path separators; consider using the Path API (e.g., Path#normalize, Path#getNameCount or Path#subpath) to drop trailing separators instead of `toString().replace(...)`. ```suggestion Path securePath = trimTrailingSeparator(targetPath); return securePath; ``` ########## drools-util/src/main/java/org/drools/util/PathUtils.java: ########## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.drools.util; + +import java.nio.file.Path; +import java.nio.file.Paths; + +/** + * Class meant to provide utility methods specific to <code>Path</code> management + */ +public class PathUtils { + + private PathUtils() { + } + + public static Path getSecuredPath(Path basePath, String userPathStr) { + Path targetPath = basePath.resolve(userPathStr).normalize(); + + if (!targetPath.startsWith(basePath)) { + throw new SecurityException("Path traversal attempt detected: " + userPathStr); + } + + String securePath = trimTrailingSeparator(targetPath.toString().replace('\\', '/')); + return Paths.get(securePath); + } + + public static Path getSecuredPath(String basePathStr, String userPathStr) { + Path basePath = Paths.get(basePathStr).normalize(); + return getSecuredPath(basePath, userPathStr); + } + + public static String trimTrailingSeparator(String p) { + return !p.isEmpty() && p.charAt( p.length() -1 ) == '/' ? p.substring( 0, p.length() -1 ) : p; Review Comment: This method only trims forward slashes; if used elsewhere on Windows it may leave a trailing backslash. Consider handling both `/` and `\\` or use Path API methods to normalize separators. ```suggestion if (p.isEmpty()) { return p; } char lastChar = p.charAt(p.length() - 1); return (lastChar == '/' || lastChar == '\\') ? p.substring(0, p.length() - 1) : p; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
