Adarshvk98 commented on code in PR #3155:
URL:
https://github.com/apache/incubator-kie-tools/pull/3155#discussion_r2106686711
##########
packages/import-java-classes-component/src/components/ImportJavaClasses/model/JavaClass.ts:
##########
@@ -26,11 +26,14 @@ export class JavaClass {
public fields: JavaField[];
/** It indicates if the fields has been loaded, in order to support empty
fields Java Classes */
public fieldsLoaded: boolean;
+ /** It indicates if there is an external conflict */
+ public isExternalConflict: boolean;
Review Comment:
I think we shouldn't add `isExternalConflict` here. May be, we could create
a new type that extends `JavaClass` ? This is because this variable is only
used to check for conflicts. So, instead of modifying the existing type, let’s
create a new type for conflicts and non-conflicts, which should extend from
`JavaClass`. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
