tiagobento commented on code in PR #3161:
URL:
https://github.com/apache/incubator-kie-tools/pull/3161#discussion_r2114150216
##########
packages/xml-parser-ts/src/index.ts:
##########
@@ -162,7 +162,7 @@ export function getParser<T extends object>(args: {
if (k.endsWith(":") || k === "" /* Filters only `xmlns --> URL`
mappings, since `ns` is bi-directional.*/) {
const instanceNsKey = instanceNs.get(v)?.slice(0, -1);
const originalXmlnsPropName = instanceNsKey ?
`@_xmlns:${instanceNsKey}` : `@_xmlns`;
- if (!instanceNsKey ||
!__json[args.root.element][originalXmlnsPropName]) {
+ if (instanceNsKey === undefined ||
!__json[args.root.element][originalXmlnsPropName]) {
Review Comment:
That was an intentional change to take the default namespace into
consideration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
