This is an automated email from the ASF dual-hosted git repository.

egonzalez pushed a commit to branch main
in repository 
https://gitbox.apache.org/repos/asf/incubator-kie-kogito-examples.git


The following commit(s) were added to refs/heads/main by this push:
     new 45af1f965 [incubator-kie-issues-1944] Workflow Engine: Child process 
instance not removed upon parent abort (#2104)
45af1f965 is described below

commit 45af1f965f5fc541526f79f968c333404ea33cd1
Author: Enrique <[email protected]>
AuthorDate: Thu May 29 17:27:06 2025 +0200

    [incubator-kie-issues-1944] Workflow Engine: Child process instance not 
removed upon parent abort (#2104)
---
 .../src/main/resources/application.properties                     | 4 +++-
 .../src/main/resources/application.properties                     | 2 ++
 .../src/main/resources/application.properties                     | 4 +++-
 .../src/test/java/org/kie/kogito/examples/OrdersProcessIT.java    | 1 -
 .../org/acme/travels/security/quarkus/ApprovalsProcessTest.java   | 8 +-------
 .../src/main/resources/application.properties                     | 4 +++-
 .../src/main/resources/application.properties                     | 4 +++-
 .../test/java/org/kie/kogito/examples/demo/OrdersProcessIT.java   | 7 -------
 .../java/org/acme/travels/springboot/ApprovalsProcessTest.java    | 8 +-------
 .../travels/security/oidc/springboot/ApprovalsProcessTest.java    | 7 +------
 .../acme/travels/security/springboot/ApprovalsProcessTest.java    | 7 +------
 11 files changed, 18 insertions(+), 38 deletions(-)

diff --git 
a/kogito-quarkus-examples/process-kafka-avro-multi-quarkus/src/main/resources/application.properties
 
b/kogito-quarkus-examples/process-kafka-avro-multi-quarkus/src/main/resources/application.properties
index bbcdf8b6a..432c301f5 100644
--- 
a/kogito-quarkus-examples/process-kafka-avro-multi-quarkus/src/main/resources/application.properties
+++ 
b/kogito-quarkus-examples/process-kafka-avro-multi-quarkus/src/main/resources/application.properties
@@ -40,4 +40,6 @@ 
mp.messaging.outgoing.processedtravellers.value.serializer=org.apache.kafka.comm
 kogito.addon.messaging.outgoing.trigger.no\u0020travel=cancelledtravellers
 
 mp.messaging.outgoing.cancelledtravellers.connector=smallrye-kafka
-mp.messaging.outgoing.cancelledtravellers.value.serializer=org.apache.kafka.common.serialization.ByteArraySerializer
\ No newline at end of file
+mp.messaging.outgoing.cancelledtravellers.value.serializer=org.apache.kafka.common.serialization.ByteArraySerializer
+
+kogito.quarkus.events.threads.queueSize=10
diff --git 
a/kogito-quarkus-examples/process-kafka-multi-quarkus/src/main/resources/application.properties
 
b/kogito-quarkus-examples/process-kafka-multi-quarkus/src/main/resources/application.properties
index b96099231..9bd93337e 100644
--- 
a/kogito-quarkus-examples/process-kafka-multi-quarkus/src/main/resources/application.properties
+++ 
b/kogito-quarkus-examples/process-kafka-multi-quarkus/src/main/resources/application.properties
@@ -65,3 +65,5 @@ 
mp.messaging.outgoing.kogito-processdefinitions-events.topic=kogito-processdefin
 
mp.messaging.outgoing.kogito-processdefinitions-events.value.serializer=org.apache.kafka.common.serialization.StringSerializer
 
mp.messaging.outgoing.kogito-processdefinitions-events.auto.offset.reset=earliest
 
mp.messaging.outgoing.kogito-processdefinitions-events.group.id=kogito-kafka-multi
+
+kogito.quarkus.events.threads.queueSize=10
diff --git 
a/kogito-quarkus-examples/process-kafka-quickstart-quarkus/src/main/resources/application.properties
 
b/kogito-quarkus-examples/process-kafka-quickstart-quarkus/src/main/resources/application.properties
index 7df0e9bdc..04bfc9036 100644
--- 
a/kogito-quarkus-examples/process-kafka-quickstart-quarkus/src/main/resources/application.properties
+++ 
b/kogito-quarkus-examples/process-kafka-quickstart-quarkus/src/main/resources/application.properties
@@ -35,4 +35,6 @@ mp.messaging.incoming.travellers.auto.offset.reset=earliest
 mp.messaging.outgoing.kogito_outgoing_stream.connector=smallrye-kafka
 mp.messaging.outgoing.kogito_outgoing_stream.topic=processedtravellers
 
mp.messaging.outgoing.kogito_outgoing_stream.value.serializer=org.apache.kafka.common.serialization.StringSerializer
-mp.messaging.outgoing.kogito_outgoing_stream.group.id=kogito-kafka-one
\ No newline at end of file
+mp.messaging.outgoing.kogito_outgoing_stream.group.id=kogito-kafka-one
+
+kogito.quarkus.events.threads.queueSize=10
diff --git 
a/kogito-quarkus-examples/process-quarkus-example/src/test/java/org/kie/kogito/examples/OrdersProcessIT.java
 
b/kogito-quarkus-examples/process-quarkus-example/src/test/java/org/kie/kogito/examples/OrdersProcessIT.java
index b2c49bc78..89848fad7 100644
--- 
a/kogito-quarkus-examples/process-quarkus-example/src/test/java/org/kie/kogito/examples/OrdersProcessIT.java
+++ 
b/kogito-quarkus-examples/process-quarkus-example/src/test/java/org/kie/kogito/examples/OrdersProcessIT.java
@@ -148,7 +148,6 @@ public class OrdersProcessIT {
         childProcessInstance.completeWorkItem(workItems.get(0).getId(), null, 
policy);
 
         assertEquals(ProcessInstance.STATE_COMPLETED, 
childProcessInstance.status());
-        assertEquals(ProcessInstance.STATE_COMPLETED, 
processInstance.status());
 
         assertEmpty(orderProcess.instances());
         assertEmpty(orderItemsProcess.instances());
diff --git 
a/kogito-quarkus-examples/process-usertasks-with-security-quarkus/src/test/java/org/acme/travels/security/quarkus/ApprovalsProcessTest.java
 
b/kogito-quarkus-examples/process-usertasks-with-security-quarkus/src/test/java/org/acme/travels/security/quarkus/ApprovalsProcessTest.java
index ca90e9a6e..dc434c784 100644
--- 
a/kogito-quarkus-examples/process-usertasks-with-security-quarkus/src/test/java/org/acme/travels/security/quarkus/ApprovalsProcessTest.java
+++ 
b/kogito-quarkus-examples/process-usertasks-with-security-quarkus/src/test/java/org/acme/travels/security/quarkus/ApprovalsProcessTest.java
@@ -153,12 +153,6 @@ public class ApprovalsProcessTest {
             ut.setOutput("approved", false);
             ut.transition(DefaultUserTaskLifeCycle.COMPLETE, 
Collections.emptyMap(), userIdentity);
         });
-        
assertEquals(org.kie.api.runtime.process.ProcessInstance.STATE_COMPLETED, 
processInstance.status());
-
-        Model result = (Model) processInstance.variables();
-        assertEquals(4, result.toMap().size());
-        assertEquals(result.toMap().get("approver"), "manager");
-        assertEquals(result.toMap().get("firstLineApproval"), true);
-        assertEquals(result.toMap().get("secondLineApproval"), false);
+        assertThat(approvalsProcess.instances().stream().count()).isEqualTo(0);
     }
 }
diff --git 
a/kogito-springboot-examples/process-kafka-multi-springboot/src/main/resources/application.properties
 
b/kogito-springboot-examples/process-kafka-multi-springboot/src/main/resources/application.properties
index 4f1a6cdf9..1084bb065 100644
--- 
a/kogito-springboot-examples/process-kafka-multi-springboot/src/main/resources/application.properties
+++ 
b/kogito-springboot-examples/process-kafka-multi-springboot/src/main/resources/application.properties
@@ -22,4 +22,6 @@ spring.kafka.consumer.group-id=travellers-group
 spring.kafka.consumer.auto-offset-reset=earliest
 kogito.addon.cloudevents.kafka.kogito_incoming_stream.travellers=travellers
 kogito.addon.cloudevents.kafka.kogito_outgoing_stream=processedtravellers
-kogito.addon.cloudevents.kafka.kogito_outgoing_stream.no\u0020travel=cancelledtravellers
\ No newline at end of file
+kogito.addon.cloudevents.kafka.kogito_outgoing_stream.no\u0020travel=cancelledtravellers
+
+kogito.quarkus.events.threads.queueSize=10
\ No newline at end of file
diff --git 
a/kogito-springboot-examples/process-kafka-quickstart-springboot/src/main/resources/application.properties
 
b/kogito-springboot-examples/process-kafka-quickstart-springboot/src/main/resources/application.properties
index 830c94e82..7907ec843 100644
--- 
a/kogito-springboot-examples/process-kafka-quickstart-springboot/src/main/resources/application.properties
+++ 
b/kogito-springboot-examples/process-kafka-quickstart-springboot/src/main/resources/application.properties
@@ -21,4 +21,6 @@ spring.kafka.bootstrap-servers=localhost:9092
 spring.kafka.consumer.group-id=travellers-group
 spring.kafka.consumer.auto-offset-reset=earliest
 kogito.addon.cloudevents.kafka.kogito_incoming_stream=travellers
-kogito.addon.cloudevents.kafka.kogito_outgoing_stream=processedtravellers
\ No newline at end of file
+kogito.addon.cloudevents.kafka.kogito_outgoing_stream=processedtravellers
+
+kogito.quarkus.events.threads.queueSize=10
diff --git 
a/kogito-springboot-examples/process-springboot-example/src/test/java/org/kie/kogito/examples/demo/OrdersProcessIT.java
 
b/kogito-springboot-examples/process-springboot-example/src/test/java/org/kie/kogito/examples/demo/OrdersProcessIT.java
index 06ea627bd..13a921a0d 100644
--- 
a/kogito-springboot-examples/process-springboot-example/src/test/java/org/kie/kogito/examples/demo/OrdersProcessIT.java
+++ 
b/kogito-springboot-examples/process-springboot-example/src/test/java/org/kie/kogito/examples/demo/OrdersProcessIT.java
@@ -89,17 +89,12 @@ public class OrdersProcessIT {
         assertEquals(2, result.toMap().size());
         assertTrue(((Order) result.toMap().get("order")).getTotal() > 0);
 
-        ProcessInstances<? extends Model> orderItemProcesses = 
orderItemsProcess.instances();
-
-        ProcessInstance<?> childProcessInstance = getFirst(orderItemProcesses);
-
         IdentityProvider johnUser = IdentityProviders.of("john", 
Collections.singletonList("managers"));
         List<UserTaskInstance> userTaskInstances = 
userTasks.instances().findByIdentity(johnUser);
         userTaskInstances.forEach(ut -> {
             ut.transition(DefaultUserTaskLifeCycle.COMPLETE, 
Collections.emptyMap(), johnUser);
         });
 
-        assertEquals(ProcessInstance.STATE_COMPLETED, 
childProcessInstance.status());
         Optional<?> pi = 
orderProcess.instances().findById(processInstance.id());
         assertFalse(pi.isPresent());
 
@@ -148,8 +143,6 @@ public class OrdersProcessIT {
             ut.transition(DefaultUserTaskLifeCycle.COMPLETE, 
Collections.emptyMap(), johnUser);
         });
 
-        assertEquals(ProcessInstance.STATE_COMPLETED, 
childProcessInstance.status());
-        assertEquals(ProcessInstance.STATE_COMPLETED, 
processInstance.status());
         assertEmpty(orderProcess.instances());
         assertEmpty(orderItemsProcess.instances());
     }
diff --git 
a/kogito-springboot-examples/process-usertasks-springboot/src/test/java/org/acme/travels/springboot/ApprovalsProcessTest.java
 
b/kogito-springboot-examples/process-usertasks-springboot/src/test/java/org/acme/travels/springboot/ApprovalsProcessTest.java
index da6ba2b9b..79cfa5786 100644
--- 
a/kogito-springboot-examples/process-usertasks-springboot/src/test/java/org/acme/travels/springboot/ApprovalsProcessTest.java
+++ 
b/kogito-springboot-examples/process-usertasks-springboot/src/test/java/org/acme/travels/springboot/ApprovalsProcessTest.java
@@ -154,12 +154,6 @@ public class ApprovalsProcessTest {
             ut.setOutput("approved", false);
             ut.transition(DefaultUserTaskLifeCycle.COMPLETE, 
Collections.emptyMap(), userIdentity);
         });
-        
assertEquals(org.kie.api.runtime.process.ProcessInstance.STATE_COMPLETED, 
processInstance.status());
-
-        Model result = (Model) processInstance.variables();
-        assertEquals(4, result.toMap().size());
-        assertEquals(result.toMap().get("approver"), "manager");
-        assertEquals(result.toMap().get("firstLineApproval"), true);
-        assertEquals(result.toMap().get("secondLineApproval"), false);
+        assertThat(approvalsProcess.instances().stream().count()).isEqualTo(0);
     }
 }
diff --git 
a/kogito-springboot-examples/process-usertasks-with-security-oidc-springboot/src/test/java/org/acme/travels/security/oidc/springboot/ApprovalsProcessTest.java
 
b/kogito-springboot-examples/process-usertasks-with-security-oidc-springboot/src/test/java/org/acme/travels/security/oidc/springboot/ApprovalsProcessTest.java
index 65b3228b9..4cee05861 100644
--- 
a/kogito-springboot-examples/process-usertasks-with-security-oidc-springboot/src/test/java/org/acme/travels/security/oidc/springboot/ApprovalsProcessTest.java
+++ 
b/kogito-springboot-examples/process-usertasks-with-security-oidc-springboot/src/test/java/org/acme/travels/security/oidc/springboot/ApprovalsProcessTest.java
@@ -158,12 +158,7 @@ public class ApprovalsProcessTest {
             ut.setOutput("approved", false);
             ut.transition(DefaultUserTaskLifeCycle.COMPLETE, 
Collections.emptyMap(), userIdentity);
         });
-        
assertEquals(org.kie.api.runtime.process.ProcessInstance.STATE_COMPLETED, 
processInstance.status());
+        assertThat(approvalsProcess.instances().stream().count()).isEqualTo(0);
 
-        Model result = (Model) processInstance.variables();
-        assertEquals(4, result.toMap().size());
-        assertEquals(result.toMap().get("approver"), "manager");
-        assertEquals(result.toMap().get("firstLineApproval"), true);
-        assertEquals(result.toMap().get("secondLineApproval"), false);
     }
 }
diff --git 
a/kogito-springboot-examples/process-usertasks-with-security-springboot/src/test/java/org/acme/travels/security/springboot/ApprovalsProcessTest.java
 
b/kogito-springboot-examples/process-usertasks-with-security-springboot/src/test/java/org/acme/travels/security/springboot/ApprovalsProcessTest.java
index 28c3fc24b..bff19021e 100644
--- 
a/kogito-springboot-examples/process-usertasks-with-security-springboot/src/test/java/org/acme/travels/security/springboot/ApprovalsProcessTest.java
+++ 
b/kogito-springboot-examples/process-usertasks-with-security-springboot/src/test/java/org/acme/travels/security/springboot/ApprovalsProcessTest.java
@@ -158,12 +158,7 @@ public class ApprovalsProcessTest {
             ut.setOutput("approved", false);
             ut.transition(DefaultUserTaskLifeCycle.COMPLETE, 
Collections.emptyMap(), userIdentity);
         });
-        
assertEquals(org.kie.api.runtime.process.ProcessInstance.STATE_COMPLETED, 
processInstance.status());
 
-        Model result = (Model) processInstance.variables();
-        assertEquals(4, result.toMap().size());
-        assertEquals(result.toMap().get("approver"), "manager");
-        assertEquals(result.toMap().get("firstLineApproval"), true);
-        assertEquals(result.toMap().get("secondLineApproval"), false);
+        assertThat(approvalsProcess.instances().stream().count()).isEqualTo(0);
     }
 }


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to