gabriel-farache commented on PR #3163: URL: https://github.com/apache/incubator-kie-tools/pull/3163#issuecomment-2965766950
> I agree with Zanini. > > The functionality required by this PR is provided by [SonataflowPlatform.spec.properties](https://github.com/apache/incubator-kie-tools/blob/main/packages/sonataflow-operator/api/v1alpha08/sonataflowplatform_types.go#L65) And its description is what is needed: > > > // Properties defines the property set for a given actor in the current context. > > // For example, the workflow managed properties. One can define here a set of properties for SonataFlow deployments > > // that will be reused across every workflow deployment. > > // > > // These properties MAY NOT be propagated to a SonataFlowClusterPlatform since PropertyVarSource can only refer local context sources. > > // +optional > > Properties *PropertyPlatformSpec `json:"properties,omitempty"` > > The only thing that should be taken into account is that they become managed properties, meaning they will be applied to all workflows and unmodifiable from the managed props, only through changes to the SonataflowPlatform CR. > > There is always an option to override it per-workflow via its `-props` configmap. oh, ok, we can already set any properties we want in the `SonataFlowClusterPlatform` and they will be applied in the `-managed-props` of all deployed workflow, cool! @ishanjogi89 now we need to test that based on the per-workflow procedure we have here https://www.rhdhorchestrator.io/main/docs/serverless-workflows/configuration/token-propagation/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
