masayag commented on code in PR #3144:
URL: 
https://github.com/apache/incubator-kie-tools/pull/3144#discussion_r2152808519


##########
packages/kn-plugin-workflow/pkg/command/quarkus/create.go:
##########
@@ -50,13 +56,20 @@ func NewCreateCommand() *cobra.Command {
        # Create a project with additional extensions
        # You can add multiple extensions by separating them with a comma
        {{.Name}} create --extensions 
kogito-addons-quarkus-persistence-postgresql,quarkus-core
+
+       # Specify a profile to use for the new Quarkus project (default: dev). 
Available options: dev, preview, gitops.
+       {{.Name}} create --profile=<profile_name>
+
+       # Add persistence support to the project (default: false)
+       {{.Name}} create --with-persistence

Review Comment:
   No, my question was about the generated Dockerfile:
   In our case, we specify the extensions in the Dockerfile, e.g.
   
https://github.com/rhdhorchestrator/serverless-workflows/blob/main/pipeline/workflow-builder.Dockerfile#L24
   
   ```
   ARG 
QUARKUS_EXTENSIONS=io.quarkiverse.openapi.generator:quarkus-openapi-generator:2.9.1-lts,org.kie:kie-addons-quarkus-monitoring-sonataflow,org.kie:kogito-addons-quarkus-jobs-knative-eventing,org.kie:kie-addons-quarkus-persistence-jdbc,io.quarkus:quarkus-jdbc-postgresql:3.15.4.redhat-00001,io.quarkus:quarkus-agroal:3.15.4.redhat-00001
   ```
   
   However, in the generated Dockerfile files there is no mention for that 
QUARKUS_EXTENSIONS argument.
   This makes me wonder how the builder image is being used to build the images.
   
   I thought that for the gitops profile we'll provide a Dockerfile that relies 
on a builder image.
   According to the `gitops` profile documentation this Dockerfile should be 
used:
   
https://sonataflow.org/serverlessworkflow/main/cloud/operator/gitops-profile.html#_building_workflow_container_images
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to