yesamer commented on code in PR #6379:
URL:
https://github.com/apache/incubator-kie-drools/pull/6379#discussion_r2159250957
##########
kie-dmn/kie-dmn-core/src/main/java/org/kie/dmn/core/compiler/ItemDefinitionDependenciesSorter.java:
##########
@@ -60,6 +60,7 @@ public List<ItemDefinition> sort(List<ItemDefinition> ins) {
private void dfVisit(ItemDefinition node, List<ItemDefinition> allNodes,
Collection<ItemDefinition> visited, List<ItemDefinition> dfv) {
visited.add(node);
+ // @TODO GCARDOSI 2003 - if xmlns != namespace, the other
itemDefinitions reference xmlns, while the current one refers to namespace
Review Comment:
@gitgabrio Same as above
##########
kie-dmn/kie-dmn-core/src/main/java/org/kie/dmn/core/compiler/DMNCompilerImpl.java:
##########
@@ -617,6 +617,7 @@ private DMNType buildTypeDef(DMNCompilerContext ctx,
DMNModelImpl dmnModel, DMNN
// this is a composite type
// first, locate preregistered or create anonymous inner composite
if (topLevel == null) {
+ // @TODO and here's where the QName of Person is set, using
the model namespace as namespace
Review Comment:
@gitgabrio Are those TODO intentionally added?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
