gmunozfe commented on code in PR #3964:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/3964#discussion_r2163524940
##########
quarkus/extensions/kogito-quarkus-serverless-workflow-extension/kogito-quarkus-serverless-workflow/src/main/java/io/quarkus/restclient/runtime/RestClientBuilderFactory.java:
##########
@@ -37,10 +38,14 @@ public static RestClientBuilder build(Class<?> restClass) {
return build(restClass, Optional.empty());
}
+ public static String buildConfigKey(String configKey, Optional<String>
suffix) {
+ return suffix.map(c -> configKey +
ConfigProvider.getConfig().getOptionalValue("kogito.rest_client.config_key.separator",
String.class).orElse(".") + c).orElse(configKey);
Review Comment:
Have you consider caching separator?
`private static final String CONFIG_KEY_SEPARATOR =
ConfigProvider.getConfig()
.getOptionalValue("kogito.rest_client.config_key.separator",
String.class)
.orElse(".");`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
