Copilot commented on code in PR #3187:
URL:
https://github.com/apache/incubator-kie-tools/pull/3187#discussion_r2164671861
##########
devbox.json:
##########
@@ -24,10 +25,7 @@
"PATH":
"$DEVBOX_PROJECT_ROOT/.devbox/gopkgs/bin:$DEVBOX_PROJECT_ROOT/.devbox/pnpm-store:$PATH"
},
"shell": {
- "init_hook": [
- ". $VENV_DIR/bin/activate",
- "[[ $OSTYPE == 'darwin'* ]] && export PATH=$(echo $PATH | tr ':' '\n' |
grep -vi 'xcode\\|clang\\|cctools' | paste -sd ':' -)"
- ],
+ "init_hook": [". $VENV_DIR/bin/activate"],
Review Comment:
The removal of the conditional PATH filtering for Darwin systems from the
init_hook may affect macOS environments. Please confirm if this change is
intentional and update documentation if necessary.
```suggestion
"init_hook": [
"if [ \"$(uname)\" = \"Darwin\" ]; then",
" export PATH=\"/usr/local/bin:/opt/homebrew/bin:$PATH\"",
"fi",
". $VENV_DIR/bin/activate"
],
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
