pefernan commented on code in PR #2238:
URL:
https://github.com/apache/incubator-kie-kogito-apps/pull/2238#discussion_r2177371737
##########
data-index/data-index-storage/data-index-storage-jpa-common/src/main/java/org/kie/kogito/index/jpa/storage/ProcessInstanceEntityStorage.java:
##########
@@ -193,6 +204,18 @@ private NodeInstanceEntity updateNode(NodeInstanceEntity
nodeInstance, ProcessIn
}
ZonedDateTime eventDate = toZonedDateTime(body.getEventDate());
switch (body.getEventType()) {
+ case EVENT_TYPE_ABORTED:
+ nodeInstance.setCancelledType(CancelledType.ABORTED);
+ break;
+ case EVENT_TYPE_SKIPPED:
+ nodeInstance.setCancelledType(CancelledType.SKIPPED);
+ break;
+ case EVENT_TYPE_OBSOLETE:
+ nodeInstance.setCancelledType(CancelledType.OBSOLETE);
+ break;
+ case EVENT_TYPE_ERROR:
+ nodeInstance.setCancelledType(CancelledType.ERROR);
+ break;
Review Comment:
I'm not going to fight for this but I don't think this is a good idea,
strictly speaking if node has been `cancelled` it has not been naturally exited.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
