gitgabrio commented on code in PR #6405:
URL:
https://github.com/apache/incubator-kie-drools/pull/6405#discussion_r2239903572
##########
kie-dmn/kie-dmn-core/src/test/java/org/kie/dmn/core/DMNTypeTest.java:
##########
@@ -26,24 +26,24 @@
import org.junit.jupiter.api.Test;
import org.kie.dmn.api.core.DMNType;
import org.kie.dmn.core.compiler.DMNTypeRegistry;
-import org.kie.dmn.core.compiler.DMNTypeRegistryV15;
import org.kie.dmn.core.impl.BaseDMNTypeImpl;
import org.kie.dmn.core.impl.CompositeTypeImpl;
import org.kie.dmn.core.impl.SimpleTypeImpl;
import org.kie.dmn.feel.FEEL;
import org.kie.dmn.feel.lang.impl.FEELBuilder;
import org.kie.dmn.feel.lang.types.BuiltInType;
-import org.kie.dmn.model.v1_5.KieDMNModelInstrumentedBase;
import static org.assertj.core.api.Assertions.assertThat;
+import static org.kie.dmn.core.util.DMNVersionUtil.getLatestDMNTypeRegistry;
+import static org.kie.dmn.core.util.DMNVersionUtil.getLatestFeelReflectively;
import static org.kie.dmn.core.util.DynamicTypeUtils.entry;
import static org.kie.dmn.core.util.DynamicTypeUtils.prototype;
class DMNTypeTest {
- private static final DMNTypeRegistry typeRegistry = new
DMNTypeRegistryV15(Collections.emptyMap());
- private static final DMNType FEEL_STRING =
typeRegistry.resolveType(KieDMNModelInstrumentedBase.URI_FEEL, "string");
- private static final DMNType FEEL_NUMBER =
typeRegistry.resolveType(KieDMNModelInstrumentedBase.URI_FEEL, "number");
+ private static final DMNTypeRegistry typeRegistry =
getLatestDMNTypeRegistry();
+ private static final DMNType FEEL_STRING =
typeRegistry.resolveType(getLatestFeelReflectively(), "string");
Review Comment:
Thanks @ChinchuAjith
Could you please create a static property to store
`getLatestFeelReflectively()` and avoid multiple invocation of it ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
