tiagobento commented on code in PR #3211:
URL:
https://github.com/apache/incubator-kie-tools/pull/3211#discussion_r2248729431
##########
packages/dmn-editor/src/diagram/Diagram.tsx:
##########
@@ -918,6 +918,32 @@ export const Diagram = React.forwardRef<DiagramRef, {
container: React.RefObject
dsShape["dc:Bounds"]["@_y"] =
(parentShape["dc:Bounds"]?.["@_y"] ?? 0) +
relativePosinCurrentDS.y;
}
+ // Remove decision from decision service
+ let isInside = true;
Review Comment:
Right, what was strange to me is that you're checking whether the Decision
`isInside` for every single DRD. But I guess because the depiction is
consistent across all DRDs, this won't fail, just some extra checks. I'm ok
with this. Merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
