wmedvede commented on code in PR #2247:
URL:
https://github.com/apache/incubator-kie-kogito-apps/pull/2247#discussion_r2256389595
##########
apps-integration-tests/integration-tests-jobs-service/integration-tests-jobs-service-quarkus/integration-tests-jobs-service-quarkus-embedded/src/main/resources/shared/org/acme/travels/async.bpmn:
##########
Review Comment:
Hi @elguardian all this resources, e.g. async.bpmn, timers.bpmn, and the
serverless workflows too, are taken from a common place:
`apps-integration-tests/integration-tests-jobs-service/integration-tests-jobs-service-common/src/main/resources`
The intention is to avoid copy pasting the same processes and wofklows into
all the different integration-tests-jobs-service-xxx variants. Future changes
in any of these files, requires spreading the change in all places. It's easy
that developers forget to copy paste the change in all places.
To achive that, the different integration-tests-jobs-service-xxx variants
has the `maven-resources-plugin` configured, see below.
Unless a techical issue, I recommend to not copy paste them in all places
and let the `maven-resources-plugin` do it as its doing now. In fact, the
maven-resources-plugin is still confgured, so I think the copying is still
processed at build/test time even if you add them.
This is the configuration that the different
`integration-tests-jobs-service-xxx` has to do te magic.
<plugin>
<artifactId>maven-resources-plugin</artifactId>
<executions>
<execution>
<phase>generate-resources</phase>
<goals>
<goal>copy-resources</goal>
</goals>
<configuration>
<outputDirectory>${project.basedir}/src/main/resources/shared</outputDirectory>
<resources>
<resource>
<directory>${common.test.resources.dir}</directory>
<includes>
<include>**/*.bpmn</include>
<include>**/*.sw.json</include>
</includes>
</resource>
</resources>
</configuration>
</execution>
</executions>
</plugin>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
