Copilot commented on code in PR #6406:
URL:
https://github.com/apache/incubator-kie-drools/pull/6406#discussion_r2265968076
##########
kie-dmn/kie-dmn-validation/src/main/java/org/kie/dmn/validation/dtanalysis/DMNDTAnalyser.java:
##########
@@ -315,7 +315,7 @@ private CompilerContext feelCtx(DMNModel model,
DecisionTable dt) {
parentNode = (DMNBaseNode)
model.getBusinessKnowledgeModelByName(bkm.getName());
}
if (parentNode != null) {
- parentNode.getDependencies().keySet().forEach(k ->
feelCtx.addInputVariableType(k, BuiltInType.UNKNOWN));
+ parentNode.getDependencies().forEach((namespaceWithName,
dependency) -> feelCtx.addInputVariableType(dependency.getName(),
BuiltInType.UNKNOWN));
Review Comment:
The lambda parameter 'namespaceWithName' is not used in the lambda body.
Consider replacing it with an underscore or removing it if only the dependency
value is needed.
```suggestion
parentNode.getDependencies().forEach((_, dependency) ->
feelCtx.addInputVariableType(dependency.getName(), BuiltInType.UNKNOWN));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
