yesamer commented on code in PR #6416:
URL:
https://github.com/apache/incubator-kie-drools/pull/6416#discussion_r2273315246
##########
kie-dmn/kie-dmn-core/src/main/java/org/kie/dmn/core/compiler/DecisionServiceCompiler.java:
##########
@@ -103,12 +105,15 @@ public boolean accept(DMNNode node) {
* The qualified name of an element named E that is defined in the same
decision model as S is simply E.
* Otherwise, the qualified name is I.E, where I is the name of the import
element that refers to the model where E is defined.
*/
- private static String inputQualifiedNamePrefix(DMNNode input, DMNModelImpl
model) {
+ static String inputQualifiedNamePrefix(DMNNode input, DMNModelImpl model)
{
if (input.getModelNamespace().equals(model.getNamespace())) {
return null;
+ } else if (isInUnnamedImport(input, model)) {
+ return input.getName();
Review Comment:
Shouldn't this method return the Import prefix (as the method names
states?). Can you please clarify why in this case the input name is returned,
while in other cases the prefix is returned?
##########
kie-dmn/kie-dmn-core/src/main/java/org/kie/dmn/core/compiler/DecisionServiceCompiler.java:
##########
@@ -120,8 +125,16 @@ private static String inputQualifiedNamePrefix(DMNNode
input, DMNModelImpl model
((DMNBaseNode)input).getSource());
return null;
}
- return importAlias.get();
}
+ }
+
+ private static String resolveImportAlias(DMNNode input, DMNModelImpl
model) {
Review Comment:
Please be consistent: We refer to the prefix as:
- Name Prefix
- Import Alias
Please use the same name for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
