elguardian commented on code in PR #4023:
URL: 
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4023#discussion_r2275737763


##########
jbpm/jbpm-flow/src/main/java/org/jbpm/process/instance/LightWorkItemManager.java:
##########
@@ -211,10 +213,12 @@ private void transitionWorkItem(InternalKogitoWorkItem 
workItem, WorkItemTransit
                     case COMPLETE:
                         workItem.setState(KogitoWorkItem.COMPLETED);
                         processInstance.signalEvent("workItemCompleted", 
workItem);
+                        internalRemoveWorkItem(workItem.getStringId());

Review Comment:
   move this before the if signal. the termination already indicates the work 
item should be removed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to