tkobayas commented on PR #6419: URL: https://github.com/apache/incubator-kie-drools/pull/6419#issuecomment-3190474850
https://github.com/apache/incubator-kie-drools/commit/3de05e07086ae761fb742f8bb0ebd95f38559650 contains several changes. With regard to the change from `findMostRecentPropagationContext` to `getPropagationContext`, 3 parts were changed. - `PhreakRuleTerminalNode.doLeftTupleInsert` : This is the cause of the issue illustrated by `ActivationGroupDualFactMatchTest.testRuleAMatchingTwoFactsButNeverFires`. `findMostRecentPropagationContext` is required to maintain the right recency which triggers the match. So reverted in this PR. - `PhreakRuleTerminalNode.doLeftTupleUpdate` : I was not able to write a test case which causes a problem. As long as `PhreakRuleTerminalNode.doLeftTupleInsert` is fixed, the tuple's context's recency is valid even if the tuple is updated, I think. So not reverted in this PR. - `QueryElementNode.UnificationNodeViewChangedEventListener.rowAdded` : In this case, the context is only used as `context.getReaderContext()`. ReaderContext is shared across contexts in the same session, so replacing from `findMostRecentPropagationContext` to `getPropagationContext` is fine. Not reverted in this PR. @mariofusco Could you share your thoughts on this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
